Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-9760: Add KIP-447 protocol change to upgrade notes #8350

Merged
merged 2 commits into from Mar 26, 2020

Conversation

abbccdda
Copy link
Contributor

Adding 447 protocol change as part of the upgrade doc notable changes, and some missing stream side change as well.

image

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

docs/upgrade.html Outdated Show resolved Hide resolved
@@ -30,6 +30,15 @@ <h5><a id="upgrade_250_notable" href="#upgrade_250_notable">Notable changes in 2
<code>zookeeper.session.timeout.ms</code> has been increased from 6s to 18s and
<code>replica.lag.time.max.ms</code> from 10s to 30s.</li>
<li>New DSL operator <code>cogroup()</code> has been added for aggregating multiple streams together at once.</li>
<li>Added a new <code>KStream.toTable()</code> API to translate an input event stream into a changelog stream.</li>
<li>Added a new Serde type <code>Void</code> to represent null keys or null values from input topic.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It this worth calling out in the top level notes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess it does no harm either. At least, KIP changes are normally considered major.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never listed all KIPs at the top-level summary in the past. Only in the Streams upgrade docs we list all KS related KIPs. But if you think it's important for Kafka users in general we can also keep it.

docs/upgrade.html Outdated Show resolved Hide resolved
docs/upgrade.html Outdated Show resolved Hide resolved
docs/upgrade.html Outdated Show resolved Hide resolved
docs/upgrade.html Outdated Show resolved Hide resolved
@guozhangwang
Copy link
Contributor

LGTM modulo @mjsax comments.

@mjsax mjsax merged commit 4018f5e into apache:trunk Mar 26, 2020
mjsax pushed a commit that referenced this pull request Mar 30, 2020
Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io>
@mjsax
Copy link
Member

mjsax commented Mar 30, 2020

Merged to trunk and cherry-picked to 2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants