KAFKA-9777; Remove txn purgatory to fix race condition on txn completion #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrao
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
@hachikuji : Thanks for the PR. LGTM. Just a minor comment below.
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala
Outdated
Show resolved
Hide resolved
|
@junrao Thanks for reviewing. I addressed the review comment and I added a test case which reproduces the problem consistently on trunk. |
hachikuji
force-pushed
the
KAFKA-9777-ALT
branch
from
7ef0a4e
to
2ffe6c0
Compare
|
The one failure is this: KAFKA-9783. I will go ahead and merge. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a locking issue with DelayTxnMarker completion. Because of the reliance on the shared read lock in TransactionStateManager and the deadlock avoidance algorithm in
DelayedOperation, we cannot guarantee that a call to checkAndComplete will offer an opportunity to complete the job. This patch removes the reliance on this lock in two ways:DelayedProducecompletion when callingReplicaManager.appendRecords. As far as I can tell, this was not necessary. The lock order is always 1) state read/write lock, 2) txn metadata locks. Since we only callappendRecordswhile holding the read lock, a deadlock does not seem possible.Committer Checklist (excluded from commit message)