Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix MockAdminClient to not throw IndexOutOfBoundsException when brokerId is above the known one. #8392

Merged
merged 1 commit into from
Mar 31, 2020
Merged

MINOR: Fix MockAdminClient to not throw IndexOutOfBoundsException when brokerId is above the known one. #8392

merged 1 commit into from
Mar 31, 2020

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Mar 31, 2020

When brokerId is above the known one, an IndexOutOfBoundsException is thrown. The current handling logic likely assumed that the collection was a Map.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rajinisivaram
Copy link
Contributor

ok to test

rajinisivaram
rajinisivaram approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dajac Thanks for the PR, LGTM

@rajinisivaram
Copy link
Contributor

Test failures not related, merging to trunk.

@rajinisivaram rajinisivaram merged commit 121c769 into apache:trunk Mar 31, 2020
@dajac dajac deleted the minor-mock-admin-client branch October 6, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajinisivaram rajinisivaram rajinisivaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dajac @rajinisivaram