KAFKA-2328; merge-kafka-pr.py script should not leave user in a detached branch #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kafka-trunk-git-pr #13 FAILURE |
resetius
added a commit
to resetius/kafka
that referenced
this pull request
Jan 24, 2017
[LOGBROKER-1964] use ThreadLocal for json parser
allenxwang
pushed a commit
to allenxwang/kafka
that referenced
this pull request
Apr 9, 2019
…TimeoutTest to 2.1 * commit '3d71111c620998071a93e204c8843d6ea943e497': [NFLX] Add test to verify expiration of batches across multiple partitions on delivery.timeout.
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jun 26, 2020
…nds for lz4-java bug affecting byte buffers (apache#6679)" (apache#7769) (apache#84) TICKET = KAFKA-9203 LI_DESCRIPTION = EXIT_CRITERIA = HASH [f8129f6] ORIGINAL_DESCRIPTION = This reverts commit 90043d5 as it caused a regression in some cases: > Caused by: java.io.IOException: Stream frame descriptor corrupted > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.readHeader(KafkaLZ4BlockInputStream.java:132) > at org.apache.kafka.common.record.KafkaLZ4BlockInputStream.<init>(KafkaLZ4BlockInputStream.java:78) > at org.apache.kafka.common.record.CompressionType$4.wrapForInput(CompressionType.java:110) I will investigate why after, but I want to get the safe fix into 2.4.0. The reporter of KAFKA-9203 has verified that reverting this change makes the problem go away. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> (cherry picked from commit f8129f6) Co-authored-by: Ismael Juma <ismael@juma.me.uk>
rustd
pushed a commit
to rustd/pranavfinaldemokafka
that referenced
this pull request
Feb 9, 2024
…pache#84) Reviewers: David Jacot <djacot@confluent.io> Co-authored-by: Manikumar Reddy <manikumar.reddy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right command to get the branch name is
git rev-parse --abbrev-ref HEADinstead ofgit rev-parse HEAD. The latter gives the commit hash causing a detached branch when we checkout to it. Seems like a bug we inherited from the Spark script.