Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Rename description of flatMapValues transformation #8431

Merged
merged 1 commit into from Jan 19, 2023

Conversation

maseiler
Copy link
Contributor

@maseiler maseiler commented Apr 6, 2020

The table of (stateless) transformations uses the transformation name in the first column and a description in the second column. I adjusted the transformation name for FlatMapValues accordingly.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@maseiler
Copy link
Contributor Author

@bbejeck @ijuma

Copy link
Contributor

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbccdda
Copy link
Contributor

@maseiler Could you try to attach a screenshot of the fix?

@mjsax
Copy link
Member

mjsax commented Dec 28, 2022

@maseiler -- thanks for your PR -- could you update it so we can merge it?

@maseiler
Copy link
Contributor Author

@mjsax, I solved the merge conflict and rebased it on the latest version

Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbejeck bbejeck merged commit a1db17b into apache:trunk Jan 19, 2023
@bbejeck
Copy link
Contributor

bbejeck commented Jan 19, 2023

Merged #8431 into trunk

@bbejeck
Copy link
Contributor

bbejeck commented Jan 19, 2023

Thanks for the contribution @maseiler !

@bbejeck
Copy link
Contributor

bbejeck commented Jan 19, 2023

Hi @maseiler, can you do the same PR for the 3.3 version of the streams developer guide?
Thanks!

bbejeck pushed a commit that referenced this pull request Jan 19, 2023
The table of (stateless) transformations uses the transformation name in the first column and a description in the second column. I adjusted the transformation name for FlatMapValues accordingly.

Reviewers: Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@apache.org>
@bbejeck
Copy link
Contributor

bbejeck commented Jan 19, 2023

cherry-picked to 3.4

guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
The table of (stateless) transformations uses the transformation name in the first column and a description in the second column. I adjusted the transformation name for FlatMapValues accordingly.

Reviewers: Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants