KAFKA-7613: Enable -Xlint:rawtypes in clients, fixing warnings #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ijuma would you be able to review this? Note that |
|
@ijuma would you be able to take a look at this, since you opened the original issue? |
|
Yes, I should be able to review this tomorrow. |
ijuma
reviewed
Apr 23, 2020
build.gradle
Outdated
|
|
||
| compileTestJava.dependsOn 'processTestMessages' | ||
| compileTestJava { | ||
| options.compilerArgs << "-Xlint:rawtypes" | ||
| } |
There was a problem hiding this comment.
Would it be better to keep this in the central place where we set the javac configs, but check the project name? It will be easier to maintain that way, I think.
…sions of local decls
…(public, needs KIP?)
tombentley
force-pushed
the
KAFKA-7613-Xlint-rawtypes-client
branch
from
02c4318
to
89104e7
Compare
|
@ijuma done & rebased for conflict. |
|
@ijuma did you have any further feed back about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all existing javac warnings about use of raw types in clients add -Xlint:rawtypes to the clients the javac options in build.gradle. This addresses part of KAFKA-7613, but further work will be needed for the other warnings.