Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fixed ConsumerRecord constructor javadoc #85

Closed
wants to merge 1 commit into from
Closed

MINOR: Fixed ConsumerRecord constructor javadoc #85

wants to merge 1 commit into from

Conversation

sslavic
Copy link
Member

@sslavic sslavic commented Jul 18, 2015

Refactoring of ConsumerRecord made in 0699ff2#diff-fafe8d3a3942f3c6394927881a9389b2 left ConsumerRecord constructor javadoc inconsistent with implementation.

This patch fixes ConsumerRecord constructor javadoc to be inline with implementation.

@asfbot
Copy link

asfbot commented Jul 18, 2015

kafka-trunk-git-pr #16 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 20, 2015

kafka-trunk-git-pr #21 FAILURE
Looks like there's a problem with this pull request

@ijuma
Copy link
Contributor

ijuma commented Jul 21, 2015

A minor comment, LGTM otherwise.

@sslavic sslavic force-pushed the patch-3 branch 2 times, most recently from 33a5bbf to fd30445 Compare July 21, 2015 13:15
@sslavic
Copy link
Member Author

sslavic commented Jul 21, 2015

Made it explicit in ConsumerRecord constructor key parameter javadoc that null key is allowed, as suggested by @ijuma.

@asfbot
Copy link

asfbot commented Jul 21, 2015

kafka-trunk-git-pr #26 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 21, 2015

kafka-trunk-git-pr #27 FAILURE
Looks like there's a problem with this pull request

@guozhangwang
Copy link
Contributor

retest this please (for the asfbot)

@ijuma
Copy link
Contributor

ijuma commented Jul 29, 2015

@sslavic, I've been told by Apache Infra that you can retrigger a build by closing and reopening the PR. Would you help us test this by doing it please?

@sslavic sslavic closed this Jul 29, 2015
@sslavic sslavic reopened this Jul 29, 2015
@sslavic
Copy link
Member Author

sslavic commented Jul 29, 2015

@ijuma it worked, job was triggered https://builds.apache.org/job/kafka-trunk-git-pr/57/
But IMO that's not as nice as adding a comment, request to retest.

@ijuma
Copy link
Contributor

ijuma commented Jul 29, 2015

@sslavic thanks. I agree that this is not ideal. It's just a workaround for now until we have a better way. See https://issues.apache.org/jira/browse/BUILDS-102

@asfbot
Copy link

asfbot commented Jul 29, 2015

kafka-trunk-git-pr #57 FAILURE
Looks like there's a problem with this pull request

@sslavic
Copy link
Member Author

sslavic commented Jul 29, 2015

@ijuma one thing which remains to be consistent - core tests fail for javadoc PR :)
I don't see from build log which test was it that failed.

@ijuma
Copy link
Contributor

ijuma commented Jul 29, 2015

Frustrating!

@guozhangwang
Copy link
Contributor

@sslavic @ijuma There is no specific test failure, all I can tell is that seems to be a transient build failure. Anyways, this LGTM.

kafka.KafkaTest > testGetKafkaConfigFromArgs PASSED

kafka.server.LogRecoveryTest > testHWCheckpointNoFailuresSingleLogSegment PASSED
:core:test FAILED

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':core:test'.

    Process 'Gradle Test Executor 2' finished with non-zero exit value 1

@guozhangwang
Copy link
Contributor

@sslavic Just to be consistent with the commit message title:

https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes#ContributingCodeChanges-PullRequest

Could you change your title to MINOR: .... ?

@sslavic
MINOR: Fixed ConsumerRecord constructor javadoc
c289c4f 
Refactoring of ConsumerRecord made in apache@0699ff2#diff-fafe8d3a3942f3c6394927881a9389b2 left ConsumerRecord constructor javadoc inconsistent with implementation.

This patch fixes ConsumerRecord constructor javadoc to be inline with implementation.
@sslavic
Copy link
Member Author

sslavic commented Jul 29, 2015

@guozhangwang done. will do same for my other PRs

@sslavic sslavic changed the title Fixed ConsumerRecord constructor javadoc MINOR: Fixed ConsumerRecord constructor javadoc Jul 29, 2015
@asfbot
Copy link

asfbot commented Jul 29, 2015

kafka-trunk-git-pr #62 SUCCESS
This pull request looks good

@asfgit asfgit closed this in 1162cc1 Jul 30, 2015
@guozhangwang
Copy link
Contributor

LGTM.

resetius added a commit to resetius/kafka that referenced this pull request Jan 24, 2017
@resetius
Merge pull request apache#85 from aozeritsky/0.10.1-stbx
4b8aa9b 
0.10.1 stbx
rustd pushed a commit to rustd/pranavfinaldemokafka that referenced this pull request Feb 9, 2024
@rutvijmehta-harness @songnon
KAFKA-10149: Allow auto preferred leader election when there are ongo…
ff97dc8 
…ing partition reassignments (apache#12543) (apache#85)

Reviewers: Justine Olshan <jolshan@confluent.io>, Chris Egerton <fearthecellos@gmail.com>

Co-authored-by: Shenglong Zhang <4953397+songnon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sslavic @asfbot @ijuma @guozhangwang