Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists #8521

Merged
merged 2 commits into from
Apr 20, 2020
Merged

MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists #8521

merged 2 commits into from
Apr 20, 2020

Conversation

omkreddy
Copy link
Contributor

Following the instructions from: https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-ImplementedFeatures

This PR redirects all github commit notifications to commits@kafka.apache.org and issues, pullrequests notifications to github@kafka.apache.org mailing list.

Also enable link label JIRA notification options.

@omkreddy omkreddy requested a review from ijuma April 20, 2020 13:35
ijuma
ijuma reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice? One question below.

.asf.yaml Outdated
notifications:
commits: commits@kafka.apache.org
issues: github@kafka.apache.org
pullrequests: github@kafka.apache.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have this mailing list already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Question. I think, we dont have ``github@kafka.apache.org` yet.

Only ASF members and PMC Chair can create mailing list using : https://selfserve.apache.org/

Maybe we can request @junrao to create a new mailing address : github@kafka.apache.org

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the commits mailing list for now?

Copy link
Contributor

@ijuma ijuma Apr 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, we have a JIRA mailing list, maybe we can use that for issues and pull requests for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. we can use jira@afka.apache.org. If required, we can change later.
updated the PR.

ijuma
ijuma approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@omkreddy
Copy link
Contributor Author

@ijuma Thanks for the review. Merging to trunk.

@omkreddy omkreddy merged commit 101eca6 into apache:trunk Apr 20, 2020
ijuma added a commit to confluentinc/kafka that referenced this pull request Apr 21, 2020
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into master
48158e5 
* apache-github/trunk:
  MINOR: Fix grammar in error message for InvalidRecordException (apache#8465)
  KAFKA-9868: Reduce number of transaction log partitions for embed broker (apache#8522)
  MINOR: Adding github whitelist (apache#8523)
  MINOR: Upgrade gradle plugins and test libraries for Java 14 support (apache#8519)
  MINOR: Further reduce runtime for metrics integration tests (apache#8514)
  MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists (apache#8521)
  MINOR: Update to Gradle 6.3 (apache#7677)
  HOTFIX: fix checkstyle error of RocksDBStoreTest and flaky RocksDBTimestampedStoreTest.shouldOpenExistingStoreInRegularMode (apache#8515)
  MINOR: cleanup RocksDBStore tests  (apache#8510)
  KAFKA-9818: Fix flaky test in RecordCollectorTest (apache#8507)
  MINOR: reduce impact of trace logging in replica hot path (apache#8468)
  KAFKA-6145: KIP-441: Add test scenarios to ensure rebalance convergence (apache#8475)
  KAFKA-9881: Convert integration test to verify measurements from RocksDB to unit test (apache#8501)
  MINOR: improve test coverage for dynamic LogConfig(s) (apache#7616)
  MINOR: Switch order of sections on tumbling and hopping windows in streams doc. Tumbling windows are defined as "special case of hopping time windows" - but hopping windows currently only explained later in the docs. (apache#8505)
  KAFKA-9819: Fix flaky test in StoreChangelogReaderTest (apache#8488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@omkreddy @ijuma