Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null #8575

Closed
wants to merge 4 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 28, 2020

https://issues.apache.org/jira/browse/KAFKA-8713

https://cwiki.apache.org/confluence/display/KAFKA/KIP-581:+Value+of+optional+null+field+which+has+default+value

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch rhauch added the kip Requires or implements a KIP label Jun 11, 2020
@rgibaiev
Copy link

rgibaiev commented Jul 28, 2020

Any update? @rhauch

@rhauch
Copy link
Contributor

rhauch commented Jul 28, 2020

This PR has a conflict that has to be resolved first.

Also, KIP-581 must be passed before this can be merged. See the discussion thread for the KIP.

@pan3793
Copy link
Member Author

pan3793 commented Jul 29, 2020

Fixed the mail thread, do you have any comments on the discussion and KIP doc? @rhauch

@coded9
Copy link

coded9 commented Oct 6, 2020

Any update or possible workaround ? @rhauch

@ahamedmulaffer
Copy link

Any update or possible workaround ? @rhauch

@camilesing
Copy link

camilesing commented Nov 22, 2021

Do you have any updates or possible workaround? @rhauch @ijuma @hachikuji @guozhangwang @mjsax
@rajinisivaram @cmccabe

@AChangFeng
Copy link

Any update or possible workaround ? @rhauch

@ZoeyLiu
Copy link

ZoeyLiu commented Nov 26, 2021

Do you have any updates or possible workaround? @rhauch @ijuma @hachikuji @guozhangwang @mjsax
@rajinisivaram @cmccabe

@ahamedmulaffer
Copy link

@ZoeyLiu possible workaround you have to do at your application level for now
For example for fields which have a default value to NOT NULL but it will accept NULL for those fields you have to query that field after you capture the cdc data

@Sergii-Bilokur
Copy link

Guys do you plan to merge this PR? We also faced the problem with default values for nullable fields.

@tombentley
Copy link
Contributor

@pan3793 As far as I can see you never started a VOTE thread for your KIP. If this is something you're still interested in working on it would be good to get a vote started. If not someone else might be prepared to take it over.

@Stonepreheim
Copy link

We have run into the same issue and believe the underlying problem is with the struct get method. While searching for a potential workaround we fixed the issue by changing this line https://github.com/apache/kafka/blob/trunk/connect/api/src/main/java/org/apache/kafka/connect/data/Struct.java#L87
so that it does not replace a null value with the default. We are going to maintain our own version of the class until this is resolved. We believe a official solution should be drafted as soon as possible.

@ekeric13
Copy link

ekeric13 commented Nov 4, 2022

I think it would be great to get this in

@mimaison
Copy link
Member

mimaison commented Feb 8, 2024

This has been done in #13419. Closing.

@mimaison mimaison closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect kip Requires or implements a KIP
Projects
None yet