New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null #8575
Conversation
Any update? @rhauch |
This PR has a conflict that has to be resolved first. Also, KIP-581 must be passed before this can be merged. See the discussion thread for the KIP. |
Fixed the mail thread, do you have any comments on the discussion and KIP doc? @rhauch |
Any update or possible workaround ? @rhauch |
Any update or possible workaround ? @rhauch |
Do you have any updates or possible workaround? @rhauch @ijuma @hachikuji @guozhangwang @mjsax |
Any update or possible workaround ? @rhauch |
Do you have any updates or possible workaround? @rhauch @ijuma @hachikuji @guozhangwang @mjsax |
@ZoeyLiu possible workaround you have to do at your application level for now |
Guys do you plan to merge this PR? We also faced the problem with default values for nullable fields. |
@pan3793 As far as I can see you never started a VOTE thread for your KIP. If this is something you're still interested in working on it would be good to get a vote started. If not someone else might be prepared to take it over. |
We have run into the same issue and believe the underlying problem is with the struct get method. While searching for a potential workaround we fixed the issue by changing this line https://github.com/apache/kafka/blob/trunk/connect/api/src/main/java/org/apache/kafka/connect/data/Struct.java#L87 |
I think it would be great to get this in |
This has been done in #13419. Closing. |
https://issues.apache.org/jira/browse/KAFKA-8713
https://cwiki.apache.org/confluence/display/KAFKA/KIP-581:+Value+of+optional+null+field+which+has+default+value
Committer Checklist (excluded from commit message)