Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-10057 optimize class ConfigCommand method alterConfig parameters #8742

Open
wants to merge 2 commits into
base: 1.1
Choose a base branch
from
Open

KAFKA-10057 optimize class ConfigCommand method alterConfig parameters #8742

wants to merge 2 commits into from

Conversation

sasukerui
Copy link

I know this parameter will be used in the future, but it is not used here

@ijuma
Copy link
Contributor

ijuma commented May 30, 2020

ok to test

ijuma
ijuma approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass.

@ijuma
Copy link
Contributor

ijuma commented Jul 6, 2020

ok to test

@ijuma
Copy link
Contributor

ijuma commented Jul 6, 2020

@sasukerui Can you please change the PR to target master?

@sasukerui
Copy link
Author

@sasukerui Can you please change the PR to target master?

ok,l see

@chia7712
Copy link
Contributor

chia7712 commented Dec 9, 2020

This PR may be invalid in trunk branch since zkClient is required ( see https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ConfigCommand.scala#L149)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

@andrewchoi5 andrewchoi5 andrewchoi5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sasukerui @ijuma @chia7712 @andrewchoi5