KAFKA-10447: Migrate tools module to JUnit 5 and mockito #9231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the groundwork for migrating other modules incrementally.
Main changes:
junit
4.13 withjunit-jupiter
andjunit-vintage
5.7.0-RC1.tools
depend onjunit-vintage
.tools
depends onjunit-jupiter
.tools
tests to JUnit 5.PushHttpMetricsReporterTest
to usemockito
instead ofpowermock
andeasymock
(powermock doesn't seem to work well with JUnit 5 and we don't need it since mockito can mock
static methods).
mockito
to 3.5.7.TestUtils
to use JUnit 5 assertions sincetools
depends on it.Unrelated clean-ups:
unit
from package names in a fewcore
tests.try/catch/fail
withassertThrows
in a number of places.CoordinatorTest
as integration test.Tested with IntelliJ and gradle. Verified that the following commands work as expected:
Committer Checklist (excluded from commit message)