KAFKA-10458; Updating controller quota does not work since Token Bucket #9272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating the MetricConfig of the KafkaMetric is reflected in the Sensor.
3 tasks
apovzner
reviewed
Sep 13, 2020
| } | ||
|
|
||
| public Stat stat() { | ||
| return this.stat; |
There was a problem hiding this comment.
nit: this is not really needed, since it's not ambiguous here as in constructor,
apovzner
approved these changes
Sep 13, 2020
rajinisivaram
approved these changes
Sep 14, 2020
| } | ||
|
|
||
| public MetricConfig config() { | ||
| return this.configSupplier.get(); |
There was a problem hiding this comment.
I guess if you are removing this. above, you could remove it here as well for consistency.
| } | ||
|
|
||
| public MetricConfig config() { | ||
| return this.configSupplier.get(); |
There was a problem hiding this comment.
I guess if you are removing this. above, you could remove it here as well for consistency.
|
@apovzner @rajinisivaram Thanks for your feedback. I have addressed your comments. |
|
@dajac Thanks for the update, test failures not related, merging to trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues that have been introduced by #9114.
When I switched the metric from
RatetoTokenBucketin theControllerMutationQuotaManager, I have mixed up the metrics. That broke the quota update path.When a quota is updated, the
ClientQuotaManagerupdates theMetricConfigof theKafkaMetric. That update was not reflected into theSensorso theSensorwas still using theMetricConfigthat it has been created with.Committer Checklist (excluded from commit message)