Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Implement ApiError#equals and hashCode #9390

Merged
merged 1 commit into from Oct 9, 2020
Merged

MINOR: Implement ApiError#equals and hashCode #9390

merged 1 commit into from Oct 9, 2020

Conversation

cmccabe
Copy link
Contributor

@cmccabe cmccabe commented Oct 7, 2020 •
edited

Implement ApiError#equals and hashCode. They are sometimes useful in tests.

@cmccabe
Copy link
Contributor Author

cmccabe commented Oct 7, 2020

ok to test

mimaison
mimaison approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmccabe
Copy link
Contributor Author

cmccabe commented Oct 8, 2020

ok to test

@cmccabe
Copy link
Contributor Author

cmccabe commented Oct 8, 2020

retest this please

@cmccabe
Copy link
Contributor Author

cmccabe commented Oct 9, 2020

test failures are unrelated flakes

@cmccabe cmccabe merged commit 46e48d7 into apache:trunk Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimaison mimaison mimaison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cmccabe @mimaison