KAFKA-3245: config for changelog replication factor #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2016 13:37
| Map<Integer, List<Integer>> newAssignment = new HashMap<>(existingAssignment); | ||
|
|
||
| for (int i = 0; i < numPartitions; i++) { | ||
| newAssignment.put(i + startIndex, Collections.singletonList(brokers.get(i + startIndex) % brokers.size())); |
There was a problem hiding this comment.
Should singletonList(broker.get(i + startIndex) % brokers.size()) be
singletonList(broker.get((i + startIndex) % brokers.size()))? @guozhangwang
There was a problem hiding this comment.
Ah that is right. Good catch!
|
Merged to trunk. |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Mar 1, 2016
guozhangwang Author: Yasuhiro Matsuda <yasuhiro@confluent.io> Reviewers: Guozhang Wang <wangguoz@gmail.com> Closes apache#948 from ymatsuda/changelog_topic_replication
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
ahuang98
pushed a commit
to ahuang98/kafka
that referenced
this pull request
Sep 29, 2023
…stem tests (apache#948) * Test: Trying to fix the breaking build due to requests v2.31.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guozhangwang