Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-10720: Document prohibition on header mutation by SMTs #9597

Merged
merged 3 commits into from Nov 26, 2020
Merged

KAFKA-10720: Document prohibition on header mutation by SMTs #9597

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2068d74
KAFKA-10720: Document prohibition on header mutation by SMTs
tombentley Nov 16, 2020
0ac5aba
Broaden language, mention Structs, Lists and Maps explicitly
tombentley Nov 16, 2020
acf7db0
Review comment
tombentley Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions connect/api/src/main/java/org/apache/kafka/connect/transforms/Transformation.java
View file
Open in desktop
Expand Up @@ -33,6 +33,11 @@ public interface Transformation<R extends ConnectRecord<R>> extends Configurable
* Apply transformation to the {@code record} and return another record object (which may be {@code record} itself) or {@code null},
* corresponding to a map or filter operation respectively.
*
* A transformation must not mutate objects reachable from the given {@code record}
* (including, but not limited to, {@link org.apache.kafka.connect.header.Headers},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change {@link org.apache.kafka.connect.header.Headers} to {@link org.apache.kafka.connect.header.Headers Headers} ?

* {@link org.apache.kafka.connect.data.Struct Structs}, {@code Lists}, and {@code Maps}).
* If such objects need to be changed, a new ConnectRecord should be created and returned.
*
* The implementation must be thread-safe.
*/
R apply(R record);
Expand Down