-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Do not print log4j for memberId required #9667
MINOR: Do not print log4j for memberId required #9667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guozhangwang Nice improvement. It makes sense to me to eliminate this "error message" as it is NOT fatal.
@@ -465,7 +465,11 @@ boolean joinGroupIfNeeded(final Timer timer) { | |||
} | |||
} else { | |||
final RuntimeException exception = future.exception(); | |||
log.info("Rebalance failed.", exception); | |||
|
|||
if (!(exception instanceof MemberIdRequiredException)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is JoinGroupResponseHandler
a better place to log error? For example, the error UNKNOWN_MEMBER_ID
is log twice.
(https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java#L605)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For another, does it need some comment to explain why MemberIdRequiredException
is excluded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I agree with you: it is a bit redundant. I think originally it is because this future may contain the error that is either from join-response or from sync-response, but at the moment both errors are logged inside the Join/SyncGroupHandler anyways. Just to maintain compatibility in case some trouble shooting scenarios are dependent on this summary entry for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an explanation here for why to skip the member.id required exception? (as it's transient)
Ack, will do. |
For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Boyang Chen <boyang@confluent.io>
For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Boyang Chen <boyang@confluent.io>
cherry-picked to 2.7 |
For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance.
Committer Checklist (excluded from commit message)