Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-10822 Force some stdout from system tests for Travis #9712

Closed
wants to merge 1 commit into from

Conversation

chia7712
Copy link
Contributor

@chia7712 chia7712 commented Dec 8, 2020

issue: https://issues.apache.org/jira/browse/KAFKA-10822

downgrade_test.py/upgrade_test.py does upgrade/downgrade for each tests. the upgrade/downgrade tasks take 10+ mins in Travis env so we ought to print something in order to avoid timeout caused by Travis.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 changed the title KAFKA-10822 Force some stdout from downgrade_test.py for Travis KAFKA-10822 Force some stdout from downgrade_test.py/upgrade_test.py for Travis Dec 8, 2020
Copy link
Contributor

@abbccdda abbccdda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is still in error?

@chia7712
Copy link
Contributor Author

Looks like the build is still in error?

Thanks for your reviews. The main purpose of this PR is to avoid timeout from downgrade_test.py/upgrade_test.py. I browse the test results and the timeout does not happen on downgrade_test.py/upgrade_test.py again. After fixing the timeout issue, I will go back to dead with the true failure of system tests.

@chia7712 chia7712 force-pushed the KAFKA-10822 branch 2 times, most recently from d71fb3f to 28600af Compare December 29, 2020 07:00
@chia7712 chia7712 changed the title KAFKA-10822 Force some stdout from downgrade_test.py/upgrade_test.py for Travis KAFKA-10822 Force some stdout from downgrade_test.py/upgrade_test.py/replication_test.py for Travis Dec 29, 2020
@chia7712 chia7712 changed the title KAFKA-10822 Force some stdout from downgrade_test.py/upgrade_test.py/replication_test.py for Travis KAFKA-10822 Force some stdout from system tests for Travis Dec 30, 2020
@chia7712
Copy link
Contributor Author

chia7712 commented Jan 4, 2021

The timeout of "no output" is caused by only replica_scale_test.py. will go back here if #9797 get merged.

@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()

self.logger.info("First pass bounce - rolling upgrade")
print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Copy link
Contributor

@ijuma ijuma Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems weird. If we want to force stdout, we should configure the logger to do so, right?

Copy link
Contributor Author

@chia7712 chia7712 Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to configure ducktape to force more output but ducktape supports only --debug. It is too noisy to me.

Another way is to make a patch to ducktape for INFO level support. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants