[KARAF-5693] Run the processing synchronously after downloads #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please |
|
@gnodet Does this synchronize both the downloading of the libraries and also the downloaded() shared activity that happens after? |
|
In other words, will this change slow down library downloads? |
|
No, it only synchronizes the shared activity and execute them in the order the libraries were called |
|
That's great! Thanks. |
|
retest this please |
|
This PR actually breaks resolver verify due to concurrent modification in in the await method (on the callback hashmap). I tried to use a |
gnodet
pushed a commit
to gnodet/karaf
that referenced
this pull request
Mar 7, 2022
[ENTESB-17815] Align Æsh with Karaf 4.2.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.