KNOX-1742 - Simple SQL Client in KnoxShell for access to JDBC sources #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
requested changes
Jan 21, 2020
gateway-shell/src/main/java/org/apache/knox/gateway/shell/jdbc/KnoxLine.java
Outdated
Show resolved
Hide resolved
gateway-shell/src/main/java/org/apache/knox/gateway/shell/KnoxSession.java
Outdated
Show resolved
Hide resolved
smolnar82
reviewed
Jan 21, 2020
gateway-shell/src/main/java/org/apache/knox/gateway/shell/jdbc/KnoxLine.java
Show resolved
Hide resolved
risdenk
approved these changes
Jan 21, 2020
risdenk
reviewed
Jan 21, 2020
| @@ -593,7 +593,26 @@ public String toString() { | |||
| String s = JsonUtils.renderAsJsonString(map); | |||
| String home = System.getProperty("user.home"); | |||
| try { | |||
| write(new File(home + File.separator + ".knoxshell" + File.separator + fileName), s); | |||
| write(new File( | |||
| home + File.separator + ".knoxshell" + File.separator + fileName), s); | |||
There was a problem hiding this comment.
Just a note for future reference:
This could be Paths.get(home, ".knoxshell", fileName).toFile() or just use the Path directly instead of manually constructing a File object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
What changes were proposed in this pull request?
Adding a simple SQL client/shell to KnoxShell for accessing JDBC data sources such as HiveServer2 and others. Rather than providing connection details on the command line for the data source, this shell leverages the DataSource persistence introduced in KNOX-2128.
Enter the SQL client, list datasources, select datasources and execute SQL query:
lmccay@strange:~/Projects/releases/knoxshell-1.4.0-SNAPSHOT$ bin/knoxshell.sh knoxline
| | ___ __ _____ | ()_ __ ___
| |/ / '_ \ / _ \ / / | | '_ \ / _
| <| | | | () > <| | | | | | __/
||__| ||___//__||| |_|\__|
powered by Apache Knox
knoxline> :ds
Name : secgov : jdbc:hive2://sme-secgov-de-01.sme-secg.a465-9q4k.cloudera.site:8443/;ssl=true;transportMode=http;httpPath=sme-secgov-de-01/cdp-proxy-api/hive
Name : anatva : jdbc:hive2://de-anatva-master0.sandbox.a465-9q4k.cloudera.site/;ssl=true;transportMode=http;httpPath=de-anatva/cdp-proxy-api/hive
Name : derby1 : jdbc:derby:codejava/webdb1
knoxline> :ds select derby1
knoxline> select * from book
select * from book
BOOK
+------------+--------------------+
| BOOK_ID | TITLE |
+------------+--------------------+
| 1 | Effective Java |
| 2 | Core Java |
| 3 | Core Apache Knox |
+------------+--------------------+
Rows: 3
knoxline> ^CClosing any open connections ...
How was this patch tested?
Manual testing of this feature and unit testing run to ensure no regressions.
Please review Knox Contributing Process before opening a pull request.