KNOX-2547 - Token-based providers should perform signature verificati… #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoty
pushed a commit
to stoty/knox
that referenced
this pull request
May 14, 2024
…on last (apache#410) Change-Id: I8004799d38b488418f5cf5bd0c5f810a5fbc8850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on last
What changes were proposed in this pull request?
Moved token signature verification to be performed after all other token validations. I've also increased the signature verification cache maximum to 250 and added the explicit removal of signature verification records for expired tokens.
How was this patch tested?
Added AbstractJWTFilterTest#testExpiredTokensEvictedFromSignatureVerificationCache() to validate the explicit eviction of expired tokens' signature verification. Ran all other existing tests.