Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2685 - Show/hide (enable/disable) Knox token management links on Home Page if required alias is created #512

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

smolnar82
Copy link
Contributor

What changes were proposed in this pull request?

The Token Integration link on the Home page must be hidden if the required knox.token.hash.key Gateway-level alias is missing.

How was this patch tested?

Manual testing.

Without the alias:
Screenshot 2021-10-31 at 21 09 54

With the alias (running bin/knoxcli.sh generate-jwk --saveAlias knox.token.hash.key):

Screenshot 2021-10-31 at 21 29 50

@lmccay
Copy link
Contributor

lmccay commented Oct 31, 2021

LGTM!

+1

Copy link
Contributor

@lmccay lmccay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@smolnar82 smolnar82 merged commit 86c1a96 into apache:master Oct 31, 2021
@smolnar82 smolnar82 deleted the KNOX-2685 branch October 31, 2021 21:16
smolnar82 added a commit that referenced this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants