Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4295 Instances displayed on Query Node are inconsistent with JobNode #1014

Merged
merged 1 commit into from Dec 30, 2019

Conversation

zhangayqian
Copy link
Contributor

Query Node can't get allParticipants because query node no need to run job scheduler, so the jobClient is null.
Job Node:
图片
Query Node:
图片

We can add instance of the mode equals ‘job’ or ‘all’ to job node list in query server, but query server can not find which job node is Leader. In order to avoid instance page display a leader as a follower by mistake, just display the Leader of job node as Job Node (Leader), the others display as Job Node.
Job Node:
图片
Query Node:
图片

@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8623cae). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1014   +/-   ##
=========================================
  Coverage          ?   25.13%           
  Complexity        ?     6178           
=========================================
  Files             ?     1431           
  Lines             ?    87168           
  Branches          ?    12191           
=========================================
  Hits              ?    21913           
  Misses            ?    63110           
  Partials          ?     2145
Impacted Files Coverage Δ Complexity Δ
...st/controller/ServiceDiscoveryStateController.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8623cae...e33d16b. Read the comment docs.

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit e28395c into apache:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants