Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4394 Update kylin dependency #1148

Closed
wants to merge 1 commit into from

Conversation

zhangayqian
Copy link
Contributor

No description provided.

@zhangayqian zhangayqian force-pushed the KYLIN-4394 branch 3 times, most recently from 43f8c10 to 2770430 Compare March 10, 2020 08:03
@codecov-io
Copy link

codecov-io commented Mar 10, 2020

Codecov Report

Merging #1148 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1148   +/-   ##
=========================================
  Coverage     25.02%   25.02%           
  Complexity     6254     6254           
=========================================
  Files          1449     1449           
  Lines         88499    88499           
  Branches      12373    12373           
=========================================
  Hits          22148    22148           
  Misses        64177    64177           
  Partials       2174     2174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6745acb...f8224c1. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 10, 2020

Pull Request Test Coverage Report for Build 5801

  • 11 of 55 (20.0%) changed or added relevant lines in 22 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 27.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java 0 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java 0 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java 0 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java 0 1 0.0%
core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java 0 1 0.0%
stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java 0 1 0.0%
stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java 1 2 50.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java 0 2 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java 0 2 0.0%
engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java 1 0%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java 2 57.95%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 5800: -0.003%
Covered Lines: 24316
Relevant Lines: 88499

💛 - Coveralls

@zhangayqian zhangayqian force-pushed the KYLIN-4394 branch 7 times, most recently from eb53db5 to baade66 Compare March 12, 2020 06:35
@zhangayqian zhangayqian marked this pull request as ready for review March 12, 2020 06:36
@zhangayqian zhangayqian force-pushed the KYLIN-4394 branch 4 times, most recently from cbd459b to f10d885 Compare March 12, 2020 16:12
@lgtm-com
Copy link

lgtm-com bot commented Mar 12, 2020

This pull request introduces 2 alerts when merging f10d885 into b61d498 - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request introduces 2 alerts when merging f8224c1 into 6745acb - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

@shaofengshi
Copy link
Contributor

merged manually, so close this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants