Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4521 make the default-time-filter enable #1219

Closed
wants to merge 1 commit into from

Conversation

fengpod
Copy link

@fengpod fengpod commented May 20, 2020

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

@fengpod
Copy link
Author

fengpod commented May 20, 2020

hi,
When enter or refresh the monitor page,the time-filter be set to LAST ONE WEEK,not the default value in the properties。This pr make the setting effective。

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v3.0.2-release@8d306c7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             v3.0.2-release    #1219   +/-   ##
=================================================
  Coverage                  ?   25.41%           
  Complexity                ?     6184           
=================================================
  Files                     ?     1420           
  Lines                     ?    86309           
  Branches                  ?    12096           
=================================================
  Hits                      ?    21932           
  Misses                    ?    62236           
  Partials                  ?     2141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d306c7...0329846. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the PR! Could you please open a JIRA with a description, and then use the JIRA ID in the PR commit message? You can refer to other PRs. Thanks!

@fengpod fengpod changed the title make the default-time-filter enable KYLIN-4521 make the default-time-filter enable May 25, 2020
@shaofengshi
Copy link
Contributor

merged by manual; Next time please raise to "mater" branch. Thanks for contributing to kylin!

@zhangayqian
Copy link
Contributor

Check list

  • Step 1. [OPTIONAL]Understand background/root cause/design basically(one hour EST) . Its issue type is
    • bug fix
    • new feature
    • enhancement
  • Step 2. Test cases are designed and documented (30 minutes EST).
  • Step 3. Prepare specific env, for example:
    • mock data (maybe some specific data type)
    • test env (maybe install a RDBMS instance).
  • Step 4. Verify and make sure test cases passed.
  • Step 5. Paste manual important steps and screenshots here (20 minutes EST).
    • If you find difficulty in pick most important evidence, please attach diagnosis package.
  • Step 6. Do more check in user perspective (20 minutes EST)
    • Doc need be updated? And if it is updated? Ask help for release manager if so.
    • If it is a breaking change so we should notify Kylin community? Ask help for release manager if so.
  • Step 7. Summarize this test (20 minutes EST).

Total estimate

  • 4 hours for small issue from optimistic estimate.

Note

If you find some unexpected and unrelated error/mistake, please DO report it if it is truly a mistake, I think we may research and fix it in the future.

If you find background information/root cause analysis is not complete or ambiguous, please try to contact to author or do a quick research and record what you find. It is a good chance to learn something interesting.

If you find it is not easy to design testcase, please notify release manager.

@zhangayqian
Copy link
Contributor

Test Case

  • Set kylin.web.default-time-filter=1 in kylin/properties
  • bin/kylin.sh restart

Expected result

  • Default timefilter is LAST ONE DAY

Verify test case

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants