New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4521 make the default-time-filter enable #1219
Conversation
hi, |
Codecov Report
@@ Coverage Diff @@
## v3.0.2-release #1219 +/- ##
=================================================
Coverage ? 25.41%
Complexity ? 6184
=================================================
Files ? 1420
Lines ? 86309
Branches ? 12096
=================================================
Hits ? 21932
Misses ? 62236
Partials ? 2141 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the PR! Could you please open a JIRA with a description, and then use the JIRA ID in the PR commit message? You can refer to other PRs. Thanks!
merged by manual; Next time please raise to "mater" branch. Thanks for contributing to kylin! |
Check list
Total estimate
NoteIf you find some unexpected and unrelated error/mistake, please DO report it if it is truly a mistake, I think we may research and fix it in the future. If you find background information/root cause analysis is not complete or ambiguous, please try to contact to author or do a quick research and record what you find. It is a good chance to learn something interesting. If you find it is not easy to design testcase, please notify release manager. |
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.document
branchFurther comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...