Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KYLIN-4521 make the default-time-filter enable #1219

Closed
wants to merge 1 commit into from
Closed

KYLIN-4521 make the default-time-filter enable #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2320,4 +2320,7 @@ public int getStaleJobThresholdInDays() {
return Integer.parseInt(getOptional("kylin.tool.health-check.stale-job-threshold-days", "30"));
}

public int getDefaultTimeFilter() {
return Integer.parseInt(getOptional("kylin.web.default-time-filter", "2"));
}
}
5 changes: 4 additions & 1 deletion server-base/src/main/java/org/apache/kylin/rest/controller/JobController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.List;
import java.util.Map;

import org.apache.kylin.common.KylinConfig;
import org.apache.kylin.job.JobInstance;
import org.apache.kylin.job.constant.JobStatusEnum;
import org.apache.kylin.job.constant.JobTimeFilterEnum;
Expand Down Expand Up @@ -68,9 +69,11 @@ public List<JobInstance> list(JobListRequest jobRequest) {
}
}

JobTimeFilterEnum timeFilter = JobTimeFilterEnum.LAST_ONE_WEEK;
JobTimeFilterEnum timeFilter = null;
if (null != jobRequest.getTimeFilter()) {
timeFilter = JobTimeFilterEnum.getByCode(jobRequest.getTimeFilter());
} else {
timeFilter = JobTimeFilterEnum.getByCode(KylinConfig.getInstanceFromEnv().getDefaultTimeFilter());
}

JobService.JobSearchMode jobSearchMode = JobService.JobSearchMode.CUBING_ONLY;
Expand Down