Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch commits sync #140

Merged
merged 8 commits into from May 27, 2018
Merged

Batch commits sync #140

merged 8 commits into from May 27, 2018

Conversation

liyang-gmt8
Copy link

No description provided.

@asfgit
Copy link

asfgit commented May 26, 2018

Can one of the admins verify this patch?

@liyang-gmt8
Copy link
Author

liyang-gmt8 commented May 26, 2018

CI has passed

[INFO] Apache Kylin - Tool ................................ SUCCESS [  7.187 s]
[INFO] Apache Kylin - Tool Assembly ....................... SUCCESS [  4.260 s]
[INFO] Apache Kylin - Integration Test .................... SUCCESS [  01:58 h]
[INFO] Apache Kylin - Tomcat Extension 2.4.0-SNAPSHOT ..... SUCCESS [  1.876 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:04 h
[INFO] Finished at: 2018-05-26T15:23:51Z
[INFO] ------------------------------------------------------------------------
[root@sandbox kylin-master]# git log | head
commit e29fc6154ce7b808470ee68b24f9770eea569c3c
Author: nichunen <chunen.ni@kyligence.io>
Date:   Tue May 15 21:08:16 2018 +0800

    Minor, make query response with "Unknown error" if exception without message occurs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3167

  • 16 of 66 (24.24%) changed or added relevant lines in 14 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 23.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterBuildStep.java 0 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java 2 3 66.67%
engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterMergeStep.java 0 1 0.0%
server-base/src/main/java/org/apache/kylin/rest/response/CubeInstanceResponse.java 0 2 0.0%
server-base/src/main/java/org/apache/kylin/rest/service/DashboardService.java 0 3 0.0%
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/JobInfoConverter.java 0 3 0.0%
core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java 11 15 73.33%
core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java 0 4 0.0%
core-job/src/main/java/org/apache/kylin/job/JobInstance.java 0 5 0.0%
tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java 1 81.08%
server-base/src/main/java/org/apache/kylin/rest/response/CubeInstanceResponse.java 1 0.0%
core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java 7 58.21%
Totals Coverage Status
Change from base Build 3162: 0.01%
Covered Lines: 14263
Relevant Lines: 59696

💛 - Coveralls

@shaofengshi
Copy link
Contributor

Looks good, CI passed in my side.

@shaofengshi shaofengshi merged commit 2b1e9f4 into master May 27, 2018
@shaofengshi shaofengshi deleted the sync branch May 27, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants