-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-3857 Disable quote when needed #507
Conversation
hit-lacus
commented
Mar 10, 2019
- add quote for create table ddl
- add switch for turn off quote
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
============================================
+ Coverage 25.29% 25.29% +<.01%
- Complexity 5826 5828 +2
============================================
Files 1379 1379
Lines 81720 81736 +16
Branches 11444 11445 +1
============================================
+ Hits 20667 20673 +6
- Misses 59039 59048 +9
- Partials 2014 2015 +1
Continue to review full report at Codecov.
|
Local CI Test passed. |
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
Outdated
Show resolved
Hide resolved
8b806a3
to
4011eff
Compare
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
Outdated
Show resolved
Hide resolved
b138e07
to
87e90ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to me