Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3857 Disable quote when needed #507

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

hit-lacus
Copy link
Member

  1. add quote for create table ddl
  2. add switch for turn off quote

@asfgit
Copy link

asfgit commented Mar 10, 2019

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Mar 10, 2019

@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #507 into master will increase coverage by <.01%.
The diff coverage is 31.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #507      +/-   ##
============================================
+ Coverage     25.29%   25.29%   +<.01%     
- Complexity     5826     5828       +2     
============================================
  Files          1379     1379              
  Lines         81720    81736      +16     
  Branches      11444    11445       +1     
============================================
+ Hits          20667    20673       +6     
- Misses        59039    59048       +9     
- Partials       2014     2015       +1
Impacted Files Coverage Δ Complexity Δ
...pache/kylin/source/hive/GarbageCollectionStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ain/java/org/apache/kylin/job/JoinedFlatTable.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../org/apache/kylin/source/kafka/KafkaInputBase.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/kylin/source/jdbc/JdbcHiveInputBase.java 10.57% <0%> (ø) 3 <0> (ø) ⬇️
.../java/org/apache/kylin/common/KylinConfigBase.java 13.1% <0%> (-0.05%) 42 <0> (ø)
...ylin/source/jdbc/extensible/JdbcHiveInputBase.java 84% <100%> (ø) 2 <0> (ø) ⬇️
.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java 25.86% <45.45%> (+4.7%) 12 <7> (+3) ⬆️
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...ream/core/storage/columnar/ColumnarStoreCache.java 48.83% <0%> (-3.49%) 7% <0%> (ø)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595c4e2...d229fd1. Read the comment docs.

@hit-lacus
Copy link
Member Author

Local CI Test passed.

@hit-lacus hit-lacus force-pushed the KYLIN-3857 branch 2 times, most recently from 8b806a3 to 4011eff Compare March 14, 2019 01:54
@hit-lacus hit-lacus force-pushed the KYLIN-3857 branch 2 times, most recently from b138e07 to 87e90ba Compare March 25, 2019 02:55
Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 426a227 into apache:master Apr 18, 2019
@hit-lacus hit-lacus deleted the KYLIN-3857 branch March 18, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants