[KYUUBI-SHADED #33] Step 1/2: Port ZOOKEEPER-1718 to support JLine2 in ZK client 3.4 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 012b8c037f042de3616b722f73d1d7a071f448ac.
pan3793
changed the title
pan3793
changed the title
pan3793
added a commit
to pan3793/kyuubi-shaded
that referenced
this pull request
Jan 15, 2024
…ine2 in ZK client 3.4
|
Thanks, merged to master |
pan3793
added a commit
to pan3793/kyuubi-shaded
that referenced
this pull request
Jan 19, 2024
…ine2 in ZK client 3.4
pan3793
added a commit
that referenced
this pull request
Feb 20, 2024
… to support JLine2 in ZK client 3.4 ### _Why are the changes needed?_ This PR aims to port ZOOKEEPER-1718 to make the Zookeeper 3.4 to support JLine2. To gain a clear change history, I propose to split the change into 2 PRs, 1. copy [org.apache.zookeeper.ZooKeeperMain](https://raw.githubusercontent.com/apache/zookeeper/release-3.4.14/zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java) and [org.apache.zookeeper.JLineZNodeCompletor](https://raw.githubusercontent.com/apache/zookeeper/release-3.4.14/zookeeper-server/src/main/java/org/apache/zookeeper/JLineZNodeCompletor.java) from Apache Zookeeper v3.4.14 as-is 2. apply changes in ZOOKEEPER-1718 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate 1. perform `build/mvn clean package` to generate `kyuubi-relocated-zookeeper-parent/kyuubi-relocated-zookeeper-34/target/kyuubi-relocated-zookeeper-34-0.3.0-SNAPSHOT.jar` 2. download and install [apache-kyuubi-1.8.0-bin.tgz](https://dlcdn.apache.org/kyuubi/kyuubi-1.8.0/apache-kyuubi-1.8.0-bin.tgz) 3. replace `KYUUBI_HOME/jars/kyuubi-shaded-zookeeper-34-0.1.0.jar` with `kyuubi-relocated-zookeeper-34-0.3.0-SNAPSHOT.jar` 4. replace `KYUUBI_HOME/jars/jline-0.9.94.jar` with `jline-2.14.6.jar` 5. perform `bin/kyuubi-zk-cli -server xxxxx:2181` to connect a Zookeeper cluster 6. check the logs to make sure JLine is enabled and run some command to check basic functionalities ``` ... 2024-01-15 19:52:04.593 INFO org.apache.kyuubi.shaded.zookeeper.ZooKeeper: Client environment:java.class.path=...:jline-2.14.6.jar:...:kyuubi-relocated-zookeeper-34-0.3.0-SNAPSHOT.jar... ... JLine support is enabled ... ``` - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #34 from pan3793/jline2-2. e769ee8 [Cheng Pan] [KYUUBI-SHADED #33] Step 2/2: Port ZOOKEEPER-1718 to support JLine2 in ZK client 3.4 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR aims to port ZOOKEEPER-1718 to make the Zookeeper 3.4 to support JLine2.
To gain a clear change history, I propose to split the change into 2 PRs,
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request