Skip to content

Commit

Permalink
[KYUUBI #4109] [FOLLOWUP] Remove banCircularDependencies enforcer rule
Browse files Browse the repository at this point in the history
### _Why are the changes needed?_

Remove banCircularDependencies enforcer rule, as :
- the `banCircularDependencies` rule should not be introduced in #4109 as described
- style violation with unexpanded empty tag in pom which fails maven build

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4126 from bowenliang123/4109-followup.

Closes #4109

953bcaf [liangbowen] remove banCircularDependencies rule

Authored-by: liangbowen <liangbowen@gf.com.cn>
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
bowenliang123 authored and pan3793 committed Jan 9, 2023
1 parent b1ad75b commit 496d53f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2171,7 +2171,6 @@
</goals>
<configuration>
<rules>
<banCircularDependencies/>
<enforceBytecodeVersion>
<maxJdkVersion>${java.version}</maxJdkVersion>
<ignoredScopes>test</ignoredScopes>
Expand Down

0 comments on commit 496d53f

Please sign in to comment.