Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] InvalidACL appears in the engine when zookeeper acl is turned on #1176

Closed
3 tasks done
cxzl25 opened this issue Sep 28, 2021 · 0 comments
Closed
3 tasks done

[Bug] InvalidACL appears in the engine when zookeeper acl is turned on #1176

cxzl25 opened this issue Sep 28, 2021 · 0 comments

Comments

@cxzl25
Copy link
Contributor

cxzl25 commented Sep 28, 2021

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

When kyuubi.ha.zookeeper.acl.enabled=true, both service and engine will use zookeeper acl to create znode, but engine has no keytab information and cannot write information to zookeeper, throwing an exception.

Caused by: org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /kyuubi_USER/XXXX
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:124)
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:792)
	at org.apache.kyuubi.shade.org.apache.curator.framework.imps.CreateBuilderImpl$11.call(CreateBuilderImpl.java:740)

Affects Version(s)

master

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

kyuubi.ha.zookeeper.acl.enabled true

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@cxzl25 cxzl25 added the bug label Sep 28, 2021
@cxzl25 cxzl25 mentioned this issue Sep 28, 2021
Closed
3 tasks
yaooqinn pushed a commit that referenced this issue Oct 8, 2021
@cxzl25 @yaooqinn
[KYUUBI #1176] InvalidACL appears in the engine when zookeeper acl is…
9ba2aac 
… turned on

### _Why are the changes needed?_
#1176
When `kyuubi.ha.zookeeper.acl.enabled=true`, both service and engine will use zookeeper acl to create znode, but engine has no keytab information and cannot write information to zookeeper, throwing an exception.

```java
Caused by: org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /kyuubi_USER/XXXX
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:124)
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
	at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:792)
	at org.apache.kyuubi.shade.org.apache.curator.framework.imps.CreateBuilderImpl$11.call(CreateBuilderImpl.java:740)
```

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1177 from cxzl25/KYUUBI-1176.

Closes #1176

ecc08fa [sychen] fix engine acl
0b7cc2e [sychen] fix InvalidACL

Authored-by: sychen <sychen@trip.com>
Signed-off-by: Kent Yao <yao@apache.org>
(cherry picked from commit d332534)
Signed-off-by: Kent Yao <yao@apache.org>
ulysses-you pushed a commit that referenced this issue Oct 8, 2021
@cxzl25 @ulysses-you
[KYUUBI #1176][FOLLOWUP] change configuration(ha.zookeeper.acl.engine…
464fdf4 
….enabled) version

#1177
### _Why are the changes needed?_
change configuration(ha.zookeeper.acl.engine.enabled) version to `1.3.1`

### _How was this patch tested?_
- [] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [] Add screenshots for manual tests if appropriate

- [] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1193 from cxzl25/KYUUBI-1176-followup.

Closes #1176

72753ae [sychen] change config version

Authored-by: sychen <sychen@trip.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
ulysses-you pushed a commit that referenced this issue Oct 8, 2021
@cxzl25 @ulysses-you
[KYUUBI #1176][FOLLOWUP] change configuration(ha.zookeeper.acl.engine…
547b270 
….enabled) version

#1177
### _Why are the changes needed?_
change configuration(ha.zookeeper.acl.engine.enabled) version to `1.3.1`

### _How was this patch tested?_
- [] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [] Add screenshots for manual tests if appropriate

- [] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1193 from cxzl25/KYUUBI-1176-followup.

Closes #1176

72753ae [sychen] change config version

Authored-by: sychen <sychen@trip.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
(cherry picked from commit 464fdf4)
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
pan3793 added a commit that referenced this issue Oct 12, 2021
@pan3793
Revert "[KYUUBI #1176][FOLLOWUP] change configuration(ha.zookeeper.ac…
f2871e3 
…l.engine.enabled) version"

This reverts commit 547b270.
pan3793 added a commit that referenced this issue Oct 12, 2021
@pan3793
Revert "[KYUUBI #1176] InvalidACL appears in the engine when zookeepe…
b31ce17 
…r acl is turned on"

This reverts commit 9ba2aac.
pan3793 added a commit to pan3793/kyuubi that referenced this issue Oct 12, 2021
@pan3793
Revert "[KYUUBI apache#1176][FOLLOWUP] change configuration(ha.zookee…
5e7294d 
…per.acl.engine.enabled) version"

This reverts commit 464fdf4.
@pan3793 pan3793 mentioned this issue Oct 12, 2021
Closed
3 tasks
ulysses-you pushed a commit that referenced this issue Oct 13, 2021
@pan3793 @ulysses-you
[KYUUBI #1221] Revert "[KYUUBI #1176][FOLLOWUP] change configuration(…
5d7a605 
…ha.zookeeper.acl.engine.enabled) version"

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
This reverts commit 464fdf4.
The change of [KYUUBI #1176] breaks branch-1.3.
cc cxzl25

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1221 from pan3793/revert.

Closes #1221

Closes #1176

5e7294d [Cheng Pan] Revert "[KYUUBI #1176][FOLLOWUP] change configuration(ha.zookeeper.acl.engine.enabled) version"

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
@zhouyifan279 zhouyifan279 mentioned this issue Nov 11, 2021
Closed
3 tasks
zhouyifan279 pushed a commit to zhouyifan279/kyuubi that referenced this issue Nov 12, 2021
@ulysses-you @zhouyifan279
[BACKPORT] [KYUUBI apache#1176] InvalidACL appears in the engine when…
8cd735c 
… zookeeper acl is turned on

backport apache#933
@zhouyifan279 zhouyifan279 mentioned this issue Nov 12, 2021
Closed
3 tasks
ulysses-you added a commit that referenced this issue Nov 12, 2021
@charlesy6 @ulysses-you
[KYUUBI #1364] [BACKPORT] [KYUUBI #933] Enhance the detection mechani…
7f45a0b 
…sm for engine startup

### _Why are the changes needed?_
Sub task of #1361.
#1176 is based on #933 . In order to backport #1176, #933 has to be backported first.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1364 from zhouyifan279/1361.

Closes #1364

Closes #933

8cd735c [ulysses-you] [BACKPORT] [KYUUBI #1176] InvalidACL appears in the engine when zookeeper acl is turned on
42d0adc [timothy65535] [KYUUBI #933] Enhance the detection mechanism for engine startup

Lead-authored-by: timothy65535 <timothy65535@163.com>
Co-authored-by: ulysses-you <ulyssesyou18@gmail.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
zhouyifan279 added a commit to zhouyifan279/kyuubi that referenced this issue Nov 12, 2021
@zhouyifan279
[KYUUBI apache#1361][BACKPORT] [KYUUBI apache#1176] InvalidACL appear…
b89c8c2 
…s in the engine when zookeeper acl is turned on
pan3793 pushed a commit that referenced this issue Nov 12, 2021
@zhouyifan279
[KYUUBI #1361][BACKPORT] [KYUUBI #1176] InvalidACL appears in the eng…
9ccb3f3 
…ine when zookeeper acl is turned on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cxzl25