[BACKPORT] [KYUUBI #933] Enhance the detection mechanism for engine startup #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### 1. Description EngineRef use exists znode to determine whether engine started successfully or not(use the last znode), there are inconsistencies in this. So, take an idea to improve the detection mechanism by adding the started sessionid to the znone. `EngineRef` will check the sessionid in a loop after a engine started. ### 2. Here are two options **Option I, add sesssionid to the data of znode**  **Option II, add sessionid to the path of znode**  ### 3. Solution In order to be consistent with the design of server znode, prefer to choose _Option II_ . **Demo** ``` /kyuubi - serviceUri=bigdata:10009;version=1.3.0-SNAPSHOT;sequence=0000000000 /kyuubi_USER/test - serviceUri=bigdata:39869;version=1.3.0-SNAPSHOT;session=8178069f-0b22-4d06-b1c0-908094769397;sequence=0000000000] ``` Closes apache#935 from timothy65535/ky-933. Closes apache#933 ab5d6d8 [timothy65535] add issue id d21cb99 [timothy65535] compatible with back 568acf2 [timothy65535] fix error 3db8ba7 [timothy65535] move EngineRef get to Discovery 827f378 [timothy65535] rename get to getEngineBySessionId 8822931 [timothy65535] update session id using internal ab06adf [timothy65535] improve EngineRef get logic 6a1cc39 [timothy65535] update session version c94b6e5 [timothy65535] rename sessionId to createSessionId 0cc6aae [timothy65535] update ha conf d24a152 [timothy65535] update ha conf 1a67c86 [timothy65535] fix initialize sql suite b3b502d [timothy65535] [KYUUBI apache#933] Enhance the detection mechanism for engine startup Authored-by: timothy65535 <timothy65535@163.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 32b18ba)
… zookeeper acl is turned on backport apache#933
zhouyifan279
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-1.3 #1364 +/- ##
================================================
+ Coverage 80.53% 80.55% +0.02%
Complexity 11 11
================================================
Files 146 146
Lines 5390 5396 +6
Branches 643 643
================================================
+ Hits 4341 4347 +6
- Misses 669 670 +1
+ Partials 380 379 -1
Continue to review full report at Codecov.
|
zhouyifan279
changed the title
|
@ulysses-you @pan3793 @timothy65535 please help to do the review |
ulysses-you
approved these changes
Nov 12, 2021
|
thanks, merging to branch-1.3 |
ulysses-you
added a commit
that referenced
this pull request
Nov 12, 2021
…sm for engine startup ### _Why are the changes needed?_ Sub task of #1361. #1176 is based on #933 . In order to backport #1176, #933 has to be backported first. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1364 from zhouyifan279/1361. Closes #1364 Closes #933 8cd735c [ulysses-you] [BACKPORT] [KYUUBI #1176] InvalidACL appears in the engine when zookeeper acl is turned on 42d0adc [timothy65535] [KYUUBI #933] Enhance the detection mechanism for engine startup Lead-authored-by: timothy65535 <timothy65535@163.com> Co-authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Sub task of #1361.
#1176 is based on #933 . In order to backport #1176, #933 has to be backported first.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request