Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Improve the readability of ServiceControl list/get operations #2006

Closed
3 tasks done
cxzl25 opened this issue Mar 3, 2022 · 1 comment
Closed
3 tasks done

[Improvement] Improve the readability of ServiceControl list/get operations #2006

cxzl25 opened this issue Mar 3, 2022 · 1 comment
Assignees
@cxzl25
Milestone
v1.4.2

Comments

@cxzl25
Copy link
Contributor

cxzl25 commented Mar 3, 2022

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname.

kyuubi/bin/kyuubi-ctl get  server
kyuubi/bin/kyuubi-ctl list server

How should we improve?

Add a space beyond the minimum cell width in non-verbose mode.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
ulysses-you pushed a commit that referenced this issue Mar 4, 2022
@cxzl25 @ulysses-you
[KYUUBI #2006] Improve the readability of ServiceControl list/get ope…
d4b0664 
…rations

### _Why are the changes needed?_
When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname.

Add a space beyond the minimum cell width in non-verbose mode.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2007 from cxzl25/KYUUBI-2006.

Closes #2006

68bacef [sychen] Add a space beyond the minimum cell width in non-verbose mode

Authored-by: sychen <sychen@trip.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
(cherry picked from commit d8ec325)
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
@pan3793
Copy link
Member

pan3793 commented Mar 4, 2022

Related issue #1595

@ulysses-you ulysses-you added this to the v1.4.2 milestone Mar 4, 2022
wForget pushed a commit to wForget/kyuubi that referenced this issue Mar 11, 2022
@cxzl25 @wForget
[KYUUBI apache#2006] Improve the readability of ServiceControl list/g…
112e94f 
…et operations

### _Why are the changes needed?_
When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname.

Add a space beyond the minimum cell width in non-verbose mode.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes apache#2007 from cxzl25/KYUUBI-2006.

Closes apache#2006

68bacef [sychen] Add a space beyond the minimum cell width in non-verbose mode

Authored-by: sychen <sychen@trip.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cxzl25 cxzl25

Labels
None yet
Projects
None yet
Milestone
v1.4.2
Development

No branches or pull requests
3 participants
@cxzl25 @ulysses-you @pan3793