[KYUUBI #2006] Improve the readability of ServiceControl list/get operations #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now
Fix
|
yaooqinn
approved these changes
Mar 3, 2022
ulysses-you
approved these changes
Mar 4, 2022
|
thanks, merging to master |
ulysses-you
pushed a commit
that referenced
this pull request
Mar 4, 2022
…rations ### _Why are the changes needed?_ When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname. Add a space beyond the minimum cell width in non-verbose mode. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2007 from cxzl25/KYUUBI-2006. Closes #2006 68bacef [sychen] Add a space beyond the minimum cell width in non-verbose mode Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org> (cherry picked from commit d8ec325) Signed-off-by: ulysses-you <ulyssesyou@apache.org>
|
also merged to branch-1.4 |
wForget
pushed a commit
to wForget/kyuubi
that referenced
this pull request
Mar 11, 2022
…et operations ### _Why are the changes needed?_ When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname. Add a space beyond the minimum cell width in non-verbose mode. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#2007 from cxzl25/KYUUBI-2006. Closes apache#2006 68bacef [sychen] Add a space beyond the minimum cell width in non-verbose mode Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname.
Add a space beyond the minimum cell width in non-verbose mode.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request