Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Change log to reflect exactly why getting token failed #2156

Closed
3 tasks done
jiaoqingbo opened this issue Mar 17, 2022 · 1 comment
Closed
3 tasks done

[Improvement] Change log to reflect exactly why getting token failed #2156

jiaoqingbo opened this issue Mar 17, 2022 · 1 comment
Assignees
@jiaoqingbo

Comments

@jiaoqingbo
Copy link
Contributor

jiaoqingbo commented Mar 17, 2022 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

In HiveDelegationTokenProvider.scala when forget to Specify Hive metastore configurations In $KYUUBI_HOME/conf/kyuubi-defaults.conf or Place hive-site.xml into $KYUUBI_HOME/conf，the
metastoreUris will be empty，which will make the if condition return false，cause the client is null。

image

In HadoopCredentialsManager，provider.delegationTokensRequired will return false，the log
is Inaccurate，
image

How should we improve?

“Check your configuration to see if security is disabled or not.”

should be changed to “Check your configuration to see if security is disabled or not.If security is enabled,some configuration of ${provider.serviceName} is missing”

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@pan3793
Copy link
Member

pan3793 commented Mar 17, 2022

cc @zhouyifan279

jiaoqingbo added a commit to jiaoqingbo/incubator-kyuubi that referenced this issue Mar 17, 2022
@jiaoqingbo
[KYUUBI apache#2156] Change log to reflect exactly why getting token …
dc11a21 
…failed
@jiaoqingbo jiaoqingbo mentioned this issue Mar 17, 2022
Closed
3 tasks
jiaoqingbo added a commit to jiaoqingbo/incubator-kyuubi that referenced this issue Mar 18, 2022
@jiaoqingbo
[KYUUBI apache#2156][FOLLOWUP]fix cofiguration format
9c89c08
jiaoqingbo added a commit to jiaoqingbo/incubator-kyuubi that referenced this issue Mar 18, 2022
@jiaoqingbo
[KYUUBI apache#2156][FOLLOWUP] Fix configuration format in document
9862ddb
pan3793 pushed a commit that referenced this issue Mar 18, 2022
@jiaoqingbo @pan3793
[KYUUBI #2156][FOLLOWUP] Fix configuration format in document
62f685f 
### _Why are the changes needed?_

fix #2157 cofiguration format error

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2165 from jiaoqingbo/2156-followup.

Closes #2156

9862ddb [jiaoqingbo] [KYUUBI #2156][FOLLOWUP] Fix configuration format in document
47157c5 [jiaoqingbo] Merge branch 'master' into 2156-followup
9c89c08 [jiaoqingbo] [KYUUBI #2156][FOLLOWUP]fix cofiguration format
4608432 [jiaoqingbo] Merge branch 'master' into 2156
96a22e5 [jiaoqingbo] add link to doc
dc11a21 [jiaoqingbo] [KYUUBI #2156] Change log to reflect exactly why getting token failed

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 pushed a commit that referenced this issue Mar 18, 2022
@jiaoqingbo @pan3793
[KYUUBI #2156] Change log to reflect exactly why getting token failed
21ca754 
### _Why are the changes needed?_

fix #2156

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2157 from jiaoqingbo/2156.

Closes #2156

96a22e5 [jiaoqingbo] add link to doc
dc11a21 [jiaoqingbo] [KYUUBI #2156] Change log to reflect exactly why getting token failed

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 pushed a commit that referenced this issue Mar 18, 2022
@jiaoqingbo @pan3793
[KYUUBI #2156][FOLLOWUP] Fix configuration format in document
5225b54 
### _Why are the changes needed?_

fix #2157 cofiguration format error

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2165 from jiaoqingbo/2156-followup.

Closes #2156

9862ddb [jiaoqingbo] [KYUUBI #2156][FOLLOWUP] Fix configuration format in document
47157c5 [jiaoqingbo] Merge branch 'master' into 2156-followup
9c89c08 [jiaoqingbo] [KYUUBI #2156][FOLLOWUP]fix cofiguration format
4608432 [jiaoqingbo] Merge branch 'master' into 2156
96a22e5 [jiaoqingbo] add link to doc
dc11a21 [jiaoqingbo] [KYUUBI #2156] Change log to reflect exactly why getting token failed

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiaoqingbo jiaoqingbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #2156] Change log to reflect exactly why getting token failed jiaoqingbo/incubator-kyuubi
2 participants
@jiaoqingbo @pan3793