[KYUUBI #2156][FOLLOWUP] Fix configuration format in document #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Mar 18, 2022
|
If possible, when you touch the document, would you please build the document in local and paste the preview screenshot in your PR description? |
pan3793
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
=========================================
Coverage 61.31% 61.31%
Complexity 117 117
=========================================
Files 321 321
Lines 15515 15515
Branches 1992 1992
=========================================
Hits 9513 9513
Misses 5192 5192
Partials 810 810 Continue to review full report at Codecov.
|
|
the previous page |
|
after changed |
pan3793
approved these changes
Mar 18, 2022
3 tasks
|
Thanks, merging master/branch-1.5 |
pan3793
pushed a commit
that referenced
this pull request
Mar 18, 2022
### _Why are the changes needed?_ fix #2157 cofiguration format error ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2165 from jiaoqingbo/2156-followup. Closes #2156 9862ddb [jiaoqingbo] [KYUUBI #2156][FOLLOWUP] Fix configuration format in document 47157c5 [jiaoqingbo] Merge branch 'master' into 2156-followup 9c89c08 [jiaoqingbo] [KYUUBI #2156][FOLLOWUP]fix cofiguration format 4608432 [jiaoqingbo] Merge branch 'master' into 2156 96a22e5 [jiaoqingbo] add link to doc dc11a21 [jiaoqingbo] [KYUUBI #2156] Change log to reflect exactly why getting token failed Authored-by: jiaoqingbo <1178404354@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #2157 cofiguration format error
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request