Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] Support path check of LoadDataCommand #5630

Closed
3 of 4 tasks
AngersZhuuuu opened this issue Nov 6, 2023 · 0 comments
Closed
3 of 4 tasks

[TASK][EASY] Support path check of LoadDataCommand #5630

AngersZhuuuu opened this issue Nov 6, 2023 · 0 comments
Assignees
Labels
kind:subtask a subtask of umbrella ticket

Comments

@AngersZhuuuu
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Support path check of LoadDataCommand

Parent issue

#5368

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@AngersZhuuuu AngersZhuuuu added the kind:subtask a subtask of umbrella ticket label Nov 6, 2023
AngersZhuuuu added a commit to AngersZhuuuu/incubator-kyuubi that referenced this issue Nov 6, 2023
@pan3793 pan3793 closed this as completed in e45f4d9 Nov 6, 2023
tongwl added a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Nov 7, 2023
* [KYUUBI apache#5626] [UI] Fix sytle linting violation in web ui

### _Why are the changes needed?_

- To fix the style violation in web UI linting
`cd ./kyuubi-server/web-ui && pnpm run lint`

```
> kyuubi-ui1.9.0-SNAPSHOT lint /Users/bw/dev/kyuubi/kyuubi-server/web-ui
> eslint --ext .ts,vue --ignore-path .gitignore .

/Users/bw/dev/kyuubi/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts
  37:25  error  Delete `⏎····`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

 ELIFECYCLE  Command failed with exit code 1.

```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No.

Closes apache#5626 from bowenliang123/webui-lint-fix.

Closes apache#5626

b1c7d7b [Bowen Liang] web ui lint fix

Authored-by: Bowen Liang <liangbowen@gf.com.cn>
Signed-off-by: Cheng Pan <chengpan@apache.org>

* [KYUUBI apache#5579][AUTHZ] Support LogicalRelation don't have CatalogTable but have  HadoopFsRelation

### _Why are the changes needed?_
To close apache#5579
Support LogicalRelation don't have CatalogTable but have  HadoopFsRelation

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No

Closes apache#5581 from AngersZhuuuu/KYUUBI-5579.

Closes apache#5579

0298db5 [Angerszhuuuu] Update uriExtractors.scala
05a9480 [Angerszhuuuu] update
5acc919 [Angerszhuuuu] Update PrivilegesBuilder.scala
77cc7f9 [Angerszhuuuu] update
47b79c7 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
96f2006 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5579
651f3f6 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
8b5a650 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
c37d655 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5579
a71f3a6 [Angerszhuuuu] update
d4bb5b4 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
6f634f4 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5579
33282e2 [Angerszhuuuu] [KYUUBI apache#5579][AUTHZ] Support LogicalRelation don't have CatalogTable but have  HadoopFsRelation

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>

* [KYUUBI apache#5533][AUTHZ] Support merge into table command for Delta Lake

### _Why are the changes needed?_
To close apache#5533 .
Support merge into table command for Delta Lake.
https://docs.delta.io/latest/delta-update.html#upsert-into-a-table-using-merge

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No.

Closes apache#5621 from zml1206/KYUUBI-5533.

Closes apache#5533

71af24a [zml1206] Support merge into table command for Delta Lake

Authored-by: zml1206 <zhuml1206@gmail.com>
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>

* [KYUUBI apache#5630][Authz] Support path check of LoadDataCommand

### _Why are the changes needed?_
To close apache#5630
Support path check of LoadDataCommand

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No

Closes apache#5632 from AngersZhuuuu/KYUUBi-5630.

Closes apache#5630

885a1d7 [Angerszhuuuu] [KYUUBI apache#5630][Authz] Support path check of LoadDataCommand

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>

* [KYUUBI apache#5634] [UI] Smoother the icon animation on collapsing sidebar

### _Why are the changes needed?_
* Renamed type.ts to types.ts as the project uses the naming convention "types.ts" uniformly.
* Removed the title 'Swagger' from the Swagger page.
* Optimizations for Kyuubi icon display when collapsing the sidebar: make the icon and version jump smoother when expanded.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate
<img width="312" alt="image" src="https://github.com/apache/kyuubi/assets/13530192/cbe2b502-a47e-471b-ab77-dab822f793da">
<img width="1731" alt="image" src="https://github.com/apache/kyuubi/assets/13530192/61f0ed56-9328-4046-89aa-bdd1ef6f78e6">
<img width="807" alt="image" src="https://github.com/apache/kyuubi/assets/13530192/cb53a342-ce29-4181-aad5-d32bd32f9009">

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

Closes apache#5634 from tongwl/master-20231106-2.

Closes apache#5634

d2745e3 [weitong] code change
5ac8ce3 [weitong] UI optimize

Lead-authored-by: William Tong <weitong@cisco.com>
Co-authored-by: weitong <weitong@cisco.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>

* [KYUUBI apache#5624] [UI] Remove npm run build warning about NODE_ENV=production

### _Why are the changes needed?_

Before this PR, when we run `npm run build` to build production dist will meet:
```log
NODE_ENV=production is not supported in the .env file. Only NODE_ENV=development is supported to create a development build of your project. If you need to set process.env.NODE_ENV, you can set it in the Vite config instead.
```

So, let's remove `NODE_ENV=production` in `.env.production`, it's non-used.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes apache#5624 from zwangsheng/ui/remove_build_warning.

Closes apache#5624

20c21fc [zwangsheng] [UI] Remove npm run build warning about NODE_ENV=production

Authored-by: zwangsheng <binjieyang@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>

---------

Signed-off-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
Co-authored-by: Bowen Liang <liangbowen@gf.com.cn>
Co-authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Co-authored-by: zml1206 <zhuml1206@gmail.com>
Co-authored-by: zwangsheng <binjieyang@apache.org>
@pan3793 pan3793 changed the title [Subtask] Support path check of LoadDataCommand [TASK][EASY] Support path check of LoadDataCommand Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:subtask a subtask of umbrella ticket
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant