Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into this #4

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Merge master into this #4

merged 7 commits into from
Nov 7, 2023

Conversation

tongwl
Copy link
Collaborator

@tongwl tongwl commented Nov 7, 2023

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

bowenliang123 and others added 7 commits November 6, 2023 11:12
### _Why are the changes needed?_

- To fix the style violation in web UI linting
`cd ./kyuubi-server/web-ui && pnpm run lint`

```
> kyuubi-ui1.9.0-SNAPSHOT lint /Users/bw/dev/kyuubi/kyuubi-server/web-ui
> eslint --ext .ts,vue --ignore-path .gitignore .

/Users/bw/dev/kyuubi/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts
  37:25  error  Delete `⏎····`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

 ELIFECYCLE  Command failed with exit code 1.

```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No.

Closes apache#5626 from bowenliang123/webui-lint-fix.

Closes apache#5626

b1c7d7b [Bowen Liang] web ui lint fix

Authored-by: Bowen Liang <liangbowen@gf.com.cn>
Signed-off-by: Cheng Pan <chengpan@apache.org>
…gTable but have HadoopFsRelation

### _Why are the changes needed?_
To close apache#5579
Support LogicalRelation don't have CatalogTable but have  HadoopFsRelation

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No

Closes apache#5581 from AngersZhuuuu/KYUUBI-5579.

Closes apache#5579

0298db5 [Angerszhuuuu] Update uriExtractors.scala
05a9480 [Angerszhuuuu] update
5acc919 [Angerszhuuuu] Update PrivilegesBuilder.scala
77cc7f9 [Angerszhuuuu] update
47b79c7 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
96f2006 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5579
651f3f6 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
8b5a650 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
c37d655 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5579
a71f3a6 [Angerszhuuuu] update
d4bb5b4 [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
6f634f4 [Angerszhuuuu] Merge branch 'master' into KYUUBI-5579
33282e2 [Angerszhuuuu] [KYUUBI apache#5579][AUTHZ] Support LogicalRelation don't have CatalogTable but have  HadoopFsRelation

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
…a Lake

### _Why are the changes needed?_
To close apache#5533 .
Support merge into table command for Delta Lake.
https://docs.delta.io/latest/delta-update.html#upsert-into-a-table-using-merge

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No.

Closes apache#5621 from zml1206/KYUUBI-5533.

Closes apache#5533

71af24a [zml1206] Support merge into table command for Delta Lake

Authored-by: zml1206 <zhuml1206@gmail.com>
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
### _Why are the changes needed?_
To close apache#5630
Support path check of LoadDataCommand

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No

Closes apache#5632 from AngersZhuuuu/KYUUBi-5630.

Closes apache#5630

885a1d7 [Angerszhuuuu] [KYUUBI apache#5630][Authz] Support path check of LoadDataCommand

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
…idebar

### _Why are the changes needed?_
* Renamed type.ts to types.ts as the project uses the naming convention "types.ts" uniformly.
* Removed the title 'Swagger' from the Swagger page.
* Optimizations for Kyuubi icon display when collapsing the sidebar: make the icon and version jump smoother when expanded.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate
<img width="312" alt="image" src="https://github.com/apache/kyuubi/assets/13530192/cbe2b502-a47e-471b-ab77-dab822f793da">
<img width="1731" alt="image" src="https://github.com/apache/kyuubi/assets/13530192/61f0ed56-9328-4046-89aa-bdd1ef6f78e6">
<img width="807" alt="image" src="https://github.com/apache/kyuubi/assets/13530192/cb53a342-ce29-4181-aad5-d32bd32f9009">

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

Closes apache#5634 from tongwl/master-20231106-2.

Closes apache#5634

d2745e3 [weitong] code change
5ac8ce3 [weitong] UI optimize

Lead-authored-by: William Tong <weitong@cisco.com>
Co-authored-by: weitong <weitong@cisco.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
…=production

### _Why are the changes needed?_

Before this PR, when we run `npm run build` to build production dist will meet:
```log
NODE_ENV=production is not supported in the .env file. Only NODE_ENV=development is supported to create a development build of your project. If you need to set process.env.NODE_ENV, you can set it in the Vite config instead.
```

So, let's remove `NODE_ENV=production` in `.env.production`, it's non-used.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes apache#5624 from zwangsheng/ui/remove_build_warning.

Closes apache#5624

20c21fc [zwangsheng] [UI] Remove npm run build warning about NODE_ENV=production

Authored-by: zwangsheng <binjieyang@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
@tongwl tongwl merged commit 065a497 into dev-1103 Nov 7, 2023
1 check passed
pan3793 pushed a commit that referenced this pull request Nov 21, 2023
### _Why are the changes needed?_

This PR is to introduce a submit SQL editor page to close apache#5366.  Users then can submit SQL in SQL editor page to retrieve, update or do other data manipulations by Spark engine with this feature.

Once users open up a new tab in SQL editor, a new connection(session) is established with the a Kyuubi server instance. After that, users can input their SQL statements in a text box provided on the page and select the desired number of data rows to be shown in result from a dropdown list located at the right side of the run button. When the statement is executed in one of  server instances, the execution status of the job is displayed to the user.  After the statement is executed successfully , the result is displayed in the bottom of page for users.

![03_53_07](https://github.com/apache/kyuubi/assets/32693629/33806d90-7db8-4137-b8bc-872c3c42e36f)
![03_31_26](https://github.com/apache/kyuubi/assets/32693629/dd6d4226-9ddc-443e-a976-6ddd47d08d8a)

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes apache#5616 from zhaohehuhu/dev-1103.

Closes apache#5366

078d19e [William Tong] code optimize (#9)
1d839bc [William Tong] code change (#8)
ddffd19 [William Tong] fix code conflict in layout (#7)
f1fc9a2 [William Tong] UI change (#6)
265f02d [William Tong] sql UI change (#5)
4bb22f0 [William Tong] Merge branch 'master' into dev-1103
065a497 [William Tong] Merge master into branch (#4)
3438012 [William Tong] Merge pull request #3 from zhaohehuhu/dev-1103-3
a374028 [weitong] add error message for sql page
f04acf2 [William Tong] Merge branch 'master' into dev-1103
93fa6a2 [William Tong] Merge pull request #2 from zhaohehuhu/dev-1103-2
f0669ba [weitong] fix
ecdbe5c [hezhao2] fix
531761d [hezhao2] change TabPaneName to TabPanelName
466a5ba [hezhao2] remove api2
ab0661f [hezhao2] change format for table header
5f4bca5 [hezhao2] move logo picture to images folder
159c35a [hezhao2] change layout
7379c4e [weitong] code change
0ddc6d5 [weitong] sql lab page
dda47bd [hezhao2] add license
9f80e20 [weitong] sql page test

Lead-authored-by: He Zhao <hezhao2@cisco.com>
Co-authored-by: William Tong <weitong@cisco.com>
Co-authored-by: hezhao2 <hezhao2@cisco.com>
Co-authored-by: weitong <weitong@cisco.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants