-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #310] GetColumns supports DSv2 and keeps its backward compatibility #358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 80.14% 80.79% +0.65%
==========================================
Files 98 98
Lines 3535 3557 +22
Branches 412 412
==========================================
+ Hits 2833 2874 +41
+ Misses 490 469 -21
- Partials 212 214 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Security Audit for Infrastructure | 0 | 0 | 0 | 0 | ✅ |
Java Source Analyzer | 0 | 0 | 0 | 1 | ✅ |
Class File Analyzer | 0 | 6 | 0 | 0 | ❌ |
Python Security Analysis | 3 | 0 | 0 | 0 | ❌ |
Python Source Analyzer | 0 | 0 | 0 | 0 | ✅ |
Scala Security Audit | 0 | 6 | 0 | 0 | ❌ |
Shell Script Analysis | 0 | 0 | 0 | 2 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scan Summary
Tool | Critical | High | Medium | Low | Status |
---|---|---|---|---|---|
Dependency Scan (java) | 0 | 2 | 5 | 0 | ✅ |
Security Audit for Infrastructure | 0 | 0 | 0 | 0 | ✅ |
Java Source Analyzer | 0 | 0 | 0 | 1 | ✅ |
Class File Analyzer | 0 | 6 | 0 | 0 | ❌ |
Python Security Analysis | 3 | 0 | 0 | 0 | ❌ |
Python Source Analyzer | 0 | 0 | 0 | 0 | ✅ |
Scala Security Audit | 0 | 6 | 0 | 0 | ❌ |
Shell Script Analysis | 0 | 0 | 0 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
❨?❩
close #310
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request