Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #310] GetColumns supports DSv2 and keeps its backward compatibility #358

Closed
wants to merge 3 commits into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Feb 23, 2021

yaooqinn Closes #358 351 223 3 ❨?❩

close #310

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #358 (d332be5) into master (54c306b) will increase coverage by 0.65%.
The diff coverage is 88.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   80.14%   80.79%   +0.65%     
==========================================
  Files          98       98              
  Lines        3535     3557      +22     
  Branches      412      412              
==========================================
+ Hits         2833     2874      +41     
+ Misses        490      469      -21     
- Partials      212      214       +2     
Impacted Files Coverage Δ
...he/kyuubi/engine/spark/shim/CatalogShim_v3_0.scala 85.13% <75.00%> (ø)
...he/kyuubi/engine/spark/shim/CatalogShim_v2_4.scala 76.78% <75.75%> (ø)
...he/kyuubi/engine/spark/shim/SparkCatalogShim.scala 79.16% <93.10%> (ø)
...he/kyuubi/engine/spark/operation/GetCatalogs.scala 83.33% <100.00%> (ø)
...che/kyuubi/engine/spark/operation/GetColumns.scala 97.95% <100.00%> (+3.97%) ⬆️
...che/kyuubi/engine/spark/operation/GetSchemas.scala 90.00% <100.00%> (ø)
.../kyuubi/engine/spark/operation/GetTableTypes.scala 100.00% <100.00%> (ø)
...ache/kyuubi/engine/spark/operation/GetTables.scala 97.14% <100.00%> (ø)
...ine/spark/operation/SparkSQLOperationManager.scala 91.89% <100.00%> (ø)
.../scala/org/apache/kyuubi/schema/SchemaHelper.scala 98.78% <100.00%> (+1.05%) ⬆️
... and 2 more

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Security Audit for Infrastructure 0 0 0 0
Java Source Analyzer 0 0 0 1
Class File Analyzer 0 6 0 0
Python Security Analysis 3 0 0 0
Python Source Analyzer 0 0 0 0
Scala Security Audit 0 6 0 0
Shell Script Analysis 0 0 0 2

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@github-actions github-actions bot added the kind:security CVE-related label Feb 23, 2021
@yaooqinn yaooqinn linked an issue Feb 23, 2021 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Dependency Scan (java) 0 2 5 0
Security Audit for Infrastructure 0 0 0 0
Java Source Analyzer 0 0 0 1
Class File Analyzer 0 6 0 0
Python Security Analysis 3 0 0 0
Python Source Analyzer 0 0 0 0
Scala Security Audit 0 6 0 0
Shell Script Analysis 0 0 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@yaooqinn yaooqinn closed this in ee50890 Feb 23, 2021
@yaooqinn yaooqinn added this to the v1.1.0 milestone Feb 23, 2021
@yaooqinn yaooqinn deleted the 310 branch February 23, 2021 16:25
@yaooqinn yaooqinn self-assigned this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:security CVE-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetColumns supports DSv2 and keeps its backward compatibility
1 participant