Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #3968] Upgrading and migration script for Jdbc #4022

Closed
wants to merge 13 commits into from
Closed

[KYUUBI #3968] Upgrading and migration script for Jdbc #4022

wants to merge 13 commits into from

Conversation

lightning-L
Copy link
Contributor

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@turboFei
Copy link
Member 

 Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (default-cli) on project kyuubi-parent: Too many files with unapproved license: 4 See RAT report in: /home/runner/work/kyuubi/kyuubi/target/rat.txt -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (default-cli) on project kyuubi-parent: Too many files with unapproved license: 4 See RAT report in: /home/runner/work/kyuubi/kyuubi/target/rat.txt

@turboFei
Copy link
Member

thanks for driving this @lightning-L

could you add apache license header in the new added files?

@turboFei turboFei added this to the v1.7.0 milestone Dec 26, 2022
@turboFei
Copy link
Member

turboFei commented Dec 27, 2022 •
edited
Loading 

AdminRestApiSuite:
*** RUN ABORTED ***
  org.apache.kyuubi.KyuubiException: Failed to Start KyuubiServer
  at org.apache.kyuubi.service.CompositeService.$anonfun$start$1(CompositeService.scala:52)
  at org.apache.kyuubi.service.CompositeService.$anonfun$start$1$adapted(CompositeService.scala:45)
  at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
  at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
  at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
  at org.apache.kyuubi.service.CompositeService.start(CompositeService.scala:45)
  at org.apache.kyuubi.service.Serverable.start(Serverable.scala:51)
  at org.apache.kyuubi.server.KyuubiServer.start(KyuubiServer.scala:147)
  at org.apache.kyuubi.server.KyuubiServer$.startServer(KyuubiServer.scala:65)
  at org.apache.kyuubi.WithKyuubiServer.beforeAll(WithKyuubiServer.scala:62)
  ...
  Cause: org.apache.kyuubi.KyuubiException: Cannot start KyuubiRestFrontendService

https://github.com/apache/kyuubi/actions/runs/3779542104/jobs/6424890802

FYI: you can run the UT locally,
You can also check the GA log(click the upper left corner summary button).
image

@turboFei
Copy link
Member 

AdminRestApiSuite:
*** RUN ABORTED ***
  org.apache.kyuubi.KyuubiException: Failed to Start KyuubiServer
  at org.apache.kyuubi.service.CompositeService.$anonfun$start$1(CompositeService.scala:52)
  at org.apache.kyuubi.service.CompositeService.$anonfun$start$1$adapted(CompositeService.scala:45)
  at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
  at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
  at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
  at org.apache.kyuubi.service.CompositeService.start(CompositeService.scala:45)
  at org.apache.kyuubi.service.Serverable.start(Serverable.scala:51)
  at org.apache.kyuubi.server.KyuubiServer.start(KyuubiServer.scala:147)
  at org.apache.kyuubi.server.KyuubiServer$.startServer(KyuubiServer.scala:65)
  at org.apache.kyuubi.WithKyuubiServer.beforeAll(WithKyuubiServer.scala:62)
  ...
  Cause: org.apache.kyuubi.KyuubiException: Cannot start KyuubiRestFrontendService

https://github.com/apache/kyuubi/actions/runs/3779542104/jobs/6424890802

FYI: you can run the UT locally, You can also check the GA log(click the upper left corner summary button). image

The ut failure does not make sense.

would you like to rebase the code and have a try?

@lightning-L lightning-L force-pushed the kyuubi-3968 branch 3 times, most recently from 23256a0 to 70e91ed Compare December 27, 2022 07:55
turboFei
turboFei reviewed Jan 5, 2023
View reviewed changes
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala Outdated
initSchemaStream.foreach { inputStream =>
initSchemaFile.foreach { schemaFile =>
info(s"Init schema file: ${schemaFile.getAbsolutePath}")
val reader = new BufferedReader(new FileReader(schemaFile))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will raise a pr to followup it, we have to use inputStream instead of FileReader

Copy link
Member

@turboFei turboFei Jan 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:

https://github.com/lightning-L/incubator-kyuubi/pull/1/files

You can use FileReader for UT, but for binary, it is not a File, it is just a Resource.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is another follow up: #4103

you can merge the https://github.com/lightning-L/incubator-kyuubi/pull/2/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refer this: https://stackoverflow.com/questions/1429172/how-to-list-the-files-inside-a-jar-file/28057735#28057735

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the UT in #4103 has passed. @lightning-L

turboFei
turboFei approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@turboFei turboFei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turboFei turboFei mentioned this pull request Jan 7, 2023
Closed
3 tasks
@turboFei turboFei closed this in daa8d45 Jan 7, 2023
@turboFei
Copy link
Member

turboFei commented Jan 7, 2023

thanks @lightning-L , merged to master

please raise a pr to followup the version sort .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboFei turboFei turboFei approved these changes

@ulysses-you ulysses-you ulysses-you left review comments

@pan3793 pan3793 pan3793 left review comments

Assignees

@lightning-L lightning-L

Labels
kind:build module:server
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lightning-L @turboFei @ulysses-you @pan3793