[KYUUBI #3951][FOLLOWUP] Audit the rest request params #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
rest_params
branch
from
4aba5e2
to
0632860
Compare
|
cc @lightning-L with this pr, we can know the current maxRows specified by customers, and notify them to make change. and set up the server side limitation (#4388 ) |
cxzl25
approved these changes
Feb 21, 2023
cxzl25
reviewed
Feb 21, 2023
.../src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala
Outdated
Show resolved
Hide resolved
turboFei
commented
Feb 21, 2023
.../src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationAuditLogger.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Feb 21, 2023
turboFei
added a commit
that referenced
this pull request
Feb 21, 2023
### _Why are the changes needed?_ Before: ``` user=anonymous(auth:BASIC) ip=127.0.0.1 proxyIp=null method=GET uri=/api/v1/operations/5e286c5d-2880-443f-a4e8-633964dcd699/rowset protocol=HTTP/1.1 status=200 ``` After: ``` user=anonymous(auth:BASIC) ip=127.0.0.1 proxyIp=null method=GET uri=/api/v1/operations/5e286c5d-2880-443f-a4e8-633964dcd699/rowset params=maxrows=2&fetchorientation=FETCH_NEXT protocol=HTTP/1.1 status=200 ``` ``` params=maxrows=2&fetchorientation=FETCH_NEXT ``` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4389 from turboFei/rest_params. Closes #3951 6ffc1ad [fwang12] comments 61e12b1 [fwang12] nit 0632860 [fwang12] Audit the request params Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com> (cherry picked from commit d288a2b) Signed-off-by: fwang12 <fwang12@ebay.com>
|
thanks, merged to master and branch-1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Before:
After:
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request