Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Limit the max rows to get nextRowSet #4388

Closed
2 of 4 tasks
turboFei opened this issue Feb 21, 2023 · 1 comment
Closed
2 of 4 tasks

[Improvement] Limit the max rows to get nextRowSet #4388

turboFei opened this issue Feb 21, 2023 · 1 comment

Comments

@turboFei
Copy link
Member

turboFei commented Feb 21, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

It is necessary to protect the kyuubi gateway.

How should we improve?

If the max rows specified by client side is larger than the limitation, fail the request directly.

We can not choose the minimum of max rows specified by client side and server side limitation, it might break the logical that client determine whether the result set fetch is finished.

For example, for rest api:
image

Customer might check whether rowCount < maxRows, if we choose the minimum, it will cause customer mistake to think that all result set has been fetched.

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@turboFei
Copy link
Member Author

cc @lightning-L

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant