You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched in the issues and found no similar issues.
What would you like to be improved?
It is necessary to protect the kyuubi gateway.
How should we improve?
If the max rows specified by client side is larger than the limitation, fail the request directly.
We can not choose the minimum of max rows specified by client side and server side limitation, it might break the logical that client determine whether the result set fetch is finished.
For example, for rest api:
Customer might check whether rowCount < maxRows, if we choose the minimum, it will cause customer mistake to think that all result set has been fetched.
Are you willing to submit PR?
Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
No. I cannot submit a PR at this time.
The text was updated successfully, but these errors were encountered:
Code of Conduct
Search before asking
What would you like to be improved?
It is necessary to protect the kyuubi gateway.
How should we improve?
If the max rows specified by client side is larger than the limitation, fail the request directly.
We can not choose the minimum of max rows specified by client side and server side limitation, it might break the logical that client determine whether the result set fetch is finished.
For example, for rest api:
Customer might check whether
rowCount < maxRows
, if we choose the minimum, it will cause customer mistake to think that all result set has been fetched.Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: