Switch to kyuubi-relocated-hive-service-rpc
#5783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5783 +/- ##
============================================
+ Coverage 61.27% 61.46% +0.19%
Complexity 23 23
============================================
Files 608 608
Lines 36050 35941 -109
Branches 4951 4940 -11
============================================
+ Hits 22088 22092 +4
+ Misses 11567 11457 -110
+ Partials 2395 2392 -3 ☔ View full report in Codecov by Sentry. |
pan3793
changed the title
kyuubi-shaded-hive-service-rpckyuubi-relocated-hive-service-rpc
4 tasks
pan3793
added a commit
to apache/kyuubi-shaded
that referenced
this pull request
Dec 4, 2023
…m to remove deps of snappy in ZK client 3.6 ### _Why are the changes needed?_ This is step 2 of #28 > 2. remove the Snappy support (simply throw `UnsupportedOperationException`) in `org.apache.zookeeper.server.persistence.SnapStream` and snappy deps ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request - [x] Verified through apache/kyuubi#5783 Closes #29 from pan3793/snappy-2. a109d1c [Cheng Pan] [KYUUBI-SHADED #28] Step 1/2: Overwrite SnapStream to remove deps of snappy in ZK client 3.6 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
added a commit
to apache/kyuubi-shaded
that referenced
this pull request
Dec 4, 2023
…snappy in ZK client 3.6 ### _Why are the changes needed?_ This is step 2 of #28 > 2. remove the Snappy support (simply throw `UnsupportedOperationException`) in `org.apache.zookeeper.server.persistence.SnapStream` and snappy deps ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request - [x] Verified through apache/kyuubi#5783 Closes #29 from pan3793/snappy-2. a109d1c [Cheng Pan] [KYUUBI-SHADED #28] Step 1/2: Overwrite SnapStream to remove deps of snappy in ZK client 3.6 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
changed the title
kyuubi-relocated-hive-service-rpckyuubi-relocated-hive-service-rpc
|
also cc @zhouyifan279 |
wForget
approved these changes
Dec 7, 2023
ulysses-you
approved these changes
Dec 7, 2023
|
@wForget thanks for checking, I updated the PR description |
wForget
reviewed
Dec 7, 2023
| @@ -187,6 +187,21 @@ | |||
| </exclusions> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Do we need to add a comment here to explain why these dependencies are retained?
There was a problem hiding this comment.
sorry I missed this comment, it would be straightforward if the user searches the codebase with the keyword "import org.apache.thrift"
|
Thanks, merged to master |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
TL;DR there are some issues with shading Thrift RPC classes during the engine packaging phase, see details in the PR description of apache/kyuubi-shaded#20.
Describe Your Solution 🔧
This PR aims to migrate from vanilla
hive-service-rpc,libfb303,libthrifttokyuubi-relocated-hive-service-rpcintroduced in apache/kyuubi-shaded#20, the detailed works are:pom.xmland rename the package prefix in all modules, except forkyuubi-serverthere are a few places use vanilla thrift classes to access HMS to get tokenkyuubi-hive-sql-engineHive method invocationHiveRpcUtilsinkyuubi-hive-sql-enginemodule for object conversion.As part of the whole change, this PR upgrades from the Kyuubi Shaded 0.1.0 to 0.2.0, which changes the jars name. see https://kyuubi.apache.org/shaded-release/0.2.0.html
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Pass all Hive UT with Hive 3.1.3, and IT with Hive 3.1.3 and 2.3.9 (also tested with 2.1.1-cdh6.3.2)
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.