Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8 #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…river, introducing this error where the literal string 'ex_userdata' was passed during create_node intead of the actual ex_userdata kwarg.
Codecov Report
@@ Coverage Diff @@
## trunk #1426 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 370 370
Lines 77495 77495
Branches 7655 7655
=======================================
Hits 66710 66710
Misses 7885 7885
Partials 2900 2900
Continue to review full report at Codecov.
|
|
Thanks and a good catch. That was a bad bug :/ We also need to make sure we have some tests for this scenario to avoid such regressions in the future. |
|
I've added a test case (5593d6c) and merged it into trunk. Thanks for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8
Description
Release tag 2.8 reworked the kwargs based implementation of the ec2 driver, introducing this error where the literal string 'ex_userdata' was passed during create_node intead of the actual ex_userdata kwarg
Status
done, ready for review
Checklist (tick everything that applies)
Packaged tests are broken, tested manually using 3.0.0rc1
No change to documentation
No material change to code linting status