Skip to content

Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8#1426

Merged
asfgit merged 1 commit intoapache:trunkfrom
Chaffelson:fix_ec2_userdata
Feb 16, 2020
Merged

Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8#1426
asfgit merged 1 commit intoapache:trunkfrom
Chaffelson:fix_ec2_userdata

Conversation

@Chaffelson
Copy link
Copy Markdown
Contributor

Minor bugfix: ec2 driver create_node ex_userdata broken in tag 2.8

Description

Release tag 2.8 reworked the kwargs based implementation of the ec2 driver, introducing this error where the literal string 'ex_userdata' was passed during create_node intead of the actual ex_userdata kwarg

Status

done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Packaged tests are broken, tested manually using 3.0.0rc1
No change to documentation
No material change to code linting status

…river, introducing this error where the literal string 'ex_userdata' was passed during create_node intead of the actual ex_userdata kwarg.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1426 into trunk will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1426   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files         370      370           
  Lines       77495    77495           
  Branches     7655     7655           
=======================================
  Hits        66710    66710           
  Misses       7885     7885           
  Partials     2900     2900
Impacted Files Coverage Δ
libcloud/compute/drivers/ec2.py 75.27% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8518aa0...ea955ef. Read the comment docs.

@Kami
Copy link
Copy Markdown
Member

Kami commented Feb 16, 2020

Thanks and a good catch.

That was a bad bug :/

We also need to make sure we have some tests for this scenario to avoid such regressions in the future.

@asfgit asfgit merged commit ea955ef into apache:trunk Feb 16, 2020
@Kami
Copy link
Copy Markdown
Member

Kami commented Feb 16, 2020

I've added a test case (5593d6c) and merged it into trunk.

Thanks for contribution.

@Chaffelson Chaffelson deleted the fix_ec2_userdata branch February 17, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants