Libcloud 574 routes and route tables #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute_tables method
|
@Kami is there anything else I should do here ? |
| :type id: ``str`` | ||
|
|
||
| :param routes: A list of routes in the route table. | ||
| :type routes: ``list`` of :class:`EC2Route` |
There was a problem hiding this comment.
Please add . before the classes which are located in the same module. In this case:
:type routes: ``list`` of :class:`.EC2Route`
|
Ok, reviewed the whole pull request. There are some minor issues left, but it mostly looks good. Next step would be adding tests for this new functionality. Let us know if you need help with that. |
|
@zerthimon Let me know once those issues have been addressed and I will get it merged into trunk. |
…o work with objects instead of ID strings
|
Fixed issues that you found during code review. |
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for EC2 Route Tables and Routes.