[LIBCLOUD-580] node filters for ec2 driver #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1875,7 +1875,7 @@ class BaseEC2NodeDriver(NodeDriver): | |||
| 'terminated': NodeState.TERMINATED | |||
| } | |||
|
|
|||
| def list_nodes(self, ex_node_ids=None): | |||
| def list_nodes(self, ex_node_ids=None, filters=None): | |||
There was a problem hiding this comment.
Since it's an extension argument, it should be prefixed with ex - ex_filters.
Also, ex_node_ids and filters arguments are kinda overlapping (you could get the same result when using filters), but yeah, we should probably still leave it there for backward compatibility purposes.
|
Should parameter filters be renamed to ex_filters in other methods too (ex_list_networks, ex_get_security_groups, ex_list_route_tables and others in pending pull requests), for consistency ? |
|
@Kami anything else to be done here ? |
|
@zerthimon Nope. I'll go ahead and merge it shortly. Thanks. |
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend EC2 driver list_nodes() method with ability to provide filters to list only specific nodes.