[google] global IP addresses #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.id, self.name, self.address) | ||
| return '<GCEAddress id="%s" name="%s" address="%s" region="%s">' % ( | ||
| self.id, self.name, self.address, | ||
| (hasattr(self.region, "name") and self.region.name or self.region)) |
There was a problem hiding this comment.
That's fine for now, but next time, for readability purposes, I would prefer to declare a separate region variable in the method and use that.
|
Merged into trunk. Thanks. |
erjohnso
added a commit
to erjohnso/libcloud
that referenced
this pull request
Dec 1, 2014
Closes apache#394 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should've really added this as part of #390 but didn't catch it until after it had been merged.
Google Compute Engine typically has region-based IP addresses, but with the introduction of HTTP load-balancing, a
globalstatic IP addresses have been introduced. This PR is a small change to allow theGCEAddressclass to allow for 'global' to be specified as the region.New tests added to ensure both the original 'region-only' and new 'global' addresses are supported.