New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google] global IP addresses #394

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@erjohnso
Member

erjohnso commented Nov 19, 2014

I should've really added this as part of #390 but didn't catch it until after it had been merged.

Google Compute Engine typically has region-based IP addresses, but with the introduction of HTTP load-balancing, a global static IP addresses have been introduced. This PR is a small change to allow the GCEAddress class to allow for 'global' to be specified as the region.

New tests added to ensure both the original 'region-only' and new 'global' addresses are supported.

self.id, self.name, self.address)
return '<GCEAddress id="%s" name="%s" address="%s" region="%s">' % (
self.id, self.name, self.address,
(hasattr(self.region, "name") and self.region.name or self.region))

This comment has been minimized.

@Kami

Kami Nov 25, 2014

Member

That's fine for now, but next time, for readability purposes, I would prefer to declare a separate region variable in the method and use that.

@Kami

Kami Nov 25, 2014

Member

That's fine for now, but next time, for readability purposes, I would prefer to declare a separate region variable in the method and use that.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 25, 2014

Member

Merged into trunk. Thanks.

Member

Kami commented Nov 25, 2014

Merged into trunk. Thanks.

@asfgit asfgit closed this in ec4ac70 Nov 25, 2014

erjohnso added a commit to erjohnso/libcloud that referenced this pull request Dec 1, 2014

Global IP addresses handling in the GCE driver.
Closes #394

Signed-off-by: Tomaz Muraus <tomaz@apache.org>

@erjohnso erjohnso deleted the erjohnso:GCE_GlobalAddress branch Dec 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment