Fix OpenStack Alpha No Longer Returning Node Data on Server Create #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter creating a node to get all of the necessary information (name, status, ip addresses, metadata)
|
Yeah, that's an acceptable solution. We do a similar thing in some other drivers. Merged in r1208595 - http://svn.apache.org/viewvc?view=revision&revision=1208595. |
|
Thanks Kami! |
asfgit
pushed a commit
that referenced
this pull request
Jul 31, 2023
…d..d499194be d499194be README: prep 1.0.8 cf52d21d8 Remove pin on requests (fixes #41) (#42) 3ac8fed01 README: prep 1.0.7 (#40) f7e969538 requirements: constrain requests below 2.30 (#39) 28aa5e1be New issue templates (#37) 1abec09c8 action: replace `internal-be-careful-debug` (#36) 75edeacda README: prep 1.0.6 (#34) 666b1b883 Check that output file exists before opening (#33) git-subtree-dir: .github/actions/gh-action-pip-audit git-subtree-split: d499194be74aeb3bc7dbed3a224a87e1831132c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY THIS HAD TO BE DONE
OpenStack Alpha at http://alpha.auth.api.rackspacecloud.com:5000/v2.0/ has started conforming to the spec and not returning any node data back except for new password on node create.
See: http://docs.openstack.org/cactus/openstack-compute/developer/openstack-compute-api-1.1/content/CreateServers.html
"Note that when creating a server only the server ID, its links, and the admin password are guaranteed to be returned in the request. Additional attributes may be retrieved by performing subsequent GETs on the server."
Specifically the OpenStack 1.1 node driver was failing on create_node as it was attempting to fill the information to create a libcloud node from the server response (which is not just returning ID and admin password).
WHAT
The implementation I took here was to do the follow-up GET to get the node information. There is enough information returned there to make a libcloud node object, though some of it won't be filled in until the server has gone from BUILD to ACTIVE (for example, ip addresses).
I changed some of the create_node test data to match the existing asserts.