Libcloud 652 abq 3 driver #433
Conversation
|
@lochiiconnectivity Thanks. If all the providers are indeed running API v3, then removing support for v2 is fine. Otherwise, we should support both versions (we do a similar thing with CloudSigma and some other drivers) - can you please verify that? |
| # Most of the exceptions only have one error | ||
| raise LibcloudError(errors[0].findtext('message')) | ||
| else: | ||
| raise LibcloudError('unparseable body') |
There was a problem hiding this comment.
Probably better to at least return raw body in the exception?
Otherwise it will be hard to debug it without using LIBCLOUD_DEBUG.
1. style issue in (libcloud/compute/drivers/abiquo.py) 2. return whole body when a parse error is encountered to aid debugging (libcloud/common/abiquo.py)
|
For the last two points, I've pushed 0298c71 which should address these. |
|
@lochiiconnectivity Yeah, I noticed that in the API v3 change log. Didn't know this back-ward incompatible change was already introduced in v2.6. Let us know when you hear back from Abiquo. |
|
@lochiiconnectivity Any updates from Abiquo? |
|
Having spoken to Abiquo, they've confirmed 2.x is not officially supported and they've looked across their customer base and can't see anything that would cause an issue if this support (for 2.x) was removed. |
|
Thanks. Merged into trunk. |
[LIBCLOUD-652] Abiquo 2.x is no longer supported by the company, I believe all providers are running 3.x which has major changes to its API. I have updated the Abiquo compute driver.